| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:50:52 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=340.596635,conversation_content-fragment;desc="conversation_content fragment";dur=754.793235,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=264.400397,nginx;desc="NGINX";dur=0.692755,glb;desc="GLB";dur=137.405657
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8haAAlbB%2BRZ0hQvu3flVSTMypuy4KSUZgfqrYxTT6yib2kKG1zPrKNTwgiB18azo2mJ2l61AyL188xY2nDk8sYg9nZT1O3mSt0%2F6yWbYwbBitblHnjHL9K90cQCJBL3LJzmNrEDa1YthAxhbJyVABuTSoZ3CXntDxOyDp1VQJGF6bg0JJtFDQBxTVyRCa7mNIAAvuIP3%2FqHRNvdgoExKVb0pZ5pX%2BX3WwIzjW3DUmqwAUHnFcNSvHOSwGVtc77oyMCfeBY4uTn8rTfTQ0XKYfA%3D%3D--1gXHH499jfquJI2K--ypACpaqFL4jGsip%2Bwz7rzQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.95103145.1760197851; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:50:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:50:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AE42:2994BB:81C16C:AAEAA3:68EA7CDB
Block Comments: Fix translation comments to say participants in toolbar indicator by yashjawale · Pull Request #71890 · WordPress/gutenberg · GitHub
talldan
added
[Package] i18n
/packages/i18n
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
[Type] Bug
An existing feature does not function as intended
Internationalization (i18n)
Issues or PRs related to internationalization efforts
and removed
[Package] i18n
/packages/i18n
labels
Sep 25, 2025
t-hamano
added
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
and removed
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
labels
Oct 4, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Comments: Fix translation comments to say participants in toolbar indicator #71890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
talldan
merged 2 commits into
WordPress:trunk
from
yashjawale:fix/block-comments-indicator-translator-comment
Sep 25, 2025
Merged
Block Comments: Fix translation comments to say participants in toolbar indicator #71890
talldan
merged 2 commits into
WordPress:trunk
from
yashjawale:fix/block-comments-indicator-translator-comment
Sep 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
talldan
added
[Package] i18n
talldan
reviewed
Sep 25, 2025
| : sprintf( | ||
| // translators: %s: Number of comments. | ||
| // translators: %s: Number of participants. | ||
| __( '+%s more participants' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I approved the comment change, I wonder if this should use _n to handle pluralization 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that'll be a lot better...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated ✅
t-hamano
added
[Feature] Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Type] Bug
An existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Stemming from #71271
Addressed at https://wordpress.slack.com/archives/C02QB2JS7/p1758767400095899?thread_ts=1758754813.891189&cid=C02QB2JS7
In #71271, incorrect translator comments were left out that convey the count is for comments whereas they are for displaying participants.
While working on it, at one point the code used to display number of comments instead of participants.
I must've missed reverting the comment to participants...
Thanks to @talldan for bringing up the issue 🙌
Why?
Incorrect translation comments can cause confusion to translators & lead to incorrect translations.
How?
PR fixes the instances of incorrect translation labels.