You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Where does this menu styling come from (maybe the design mocks)? Should we align the style with these other menus?
This will be the next design iteration for components. The other "Actions" menus also use the same components, which was the only reason I decided to use it here.
I think the plan is to update all dropdown menus and use the same component under the hood.
Happy to revert to old styles. @jasmussen, what do you think?
Flaky tests detected in 833fa90.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #71774.
PR updates the block comment "Actions" menu design, which also fixed its positioning and now has a standard
min-width
.I've also updated the trigger label to match those used in similar components around the editors.
How?
Use the new
Menu
private component, which is also used for Post Actions in document settings.Todo
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast