You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To be honest, I'd also like to remove the textAlign block support. The reason is that block instances cannot override global styles. This is also why no other core blocks have textAlign block support. See this comment for more details.
What do you think about removing textAlign block support as a follow-up?
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in 6ef2d7c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
To be honest, I'd also like to remove the textAlign block support. The reason is that block instances cannot override global styles. This is also why no other core blocks have textAlign block support. See #62260 (comment) for more details.
What do you think about removing textAlign block support as a follow-up?
Ah thanks, I didn't realise that there are no other blocks with textAlign support. In that case, I agree we should remove this for now. Happy to do it in this PR since this isn't merged yet, or let me know if you think it should be separate!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of #71732.
Why?
We don't need the
textAlignment
attribute, astextAlign
support is already available via the typography block supports.How?
Removes the
textAlignment
attribute from the Accordion Header block, and also removes some unusedtextAlign
logic.Also removes the
clsx
import, as it's no longer being used here.Testing Instructions