You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR fixes a PHP warning sometimes triggered by the Comments block. I think it happens when a block is pre-rerendered for patterns.
PHP Warning: Undefined array key "postId" in /Users/mamaduka/Projects/gutenberg/wp-content/plugins/gutenberg/build/block-library/blocks/comments.php on line 31
Why?
Block was accessing the context value before checking its existence.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in dc60012.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
[Block] CommentsAffects the Comments Block - formerly known as Comments Query Loop[Type] Code QualityIssues or PRs that relate to code quality
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
PR fixes a PHP warning sometimes triggered by the Comments block. I think it happens when a block is pre-rerendered for patterns.
Why?
Block was accessing the context value before checking its existence.
Testing Instructions
Testing Instructions for Keyboard
Same.