| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 21:21:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=611.261523,conversation_content-fragment;desc="conversation_content fragment";dur=1216.513715,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=368.464055,nginx;desc="NGINX";dur=0.884898,glb;desc="GLB";dur=138.918877
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=k8b09zMlDMof%2BAspX4ZpOrXtC17nM64k9YQfMJ4bDGsdZ4cJCqb%2B%2BoNNKeahmYTndgXl2Jl35xJeyMckj%2FTA2oAdB4osGKb%2BlKOU2xmIgc36qOyFPy%2FmqrbJo1X5N7dB3Db2Y%2BxY8HAcgNFFkRNnNk%2Fe3Btg8yERUh4iE8xgIkA6st309sbEp%2FE12Rj6m8iagdvDb5CdzfE8qeTZiP6yw2vvJaYU6A9MBP3YWDOtXuILQGQfmhRELIpGfp1K%2Bq5fCg7NhLirw5VXm3PyBloQLA%3D%3D--rzhAbgdrvaWFKWbQ--CxL17PutrL2AmcdD1bo0qA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.990177434.1760131314; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:21:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:21:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A9FC:1FDE52:F0DB0:14A4FF:68E978F2
Block Commenting: Don't show unpinnable sidebar on mobile viewports by t-hamano · Pull Request #71834 · WordPress/gutenberg · GitHub
t-hamano
added
[Type] Bug
An existing feature does not function as intended
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
labels
Sep 23, 2025
t-hamano
added
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
and removed
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
labels
Oct 4, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Commenting: Don't show unpinnable sidebar on mobile viewports #71834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: +10 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @kunalpuri123. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
Mamaduka
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @t-hamano!
|
Nice work! |
|
Thanks for the review! |
t-hamano
added
[Feature] Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
[Type] Bug
An existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
This PR fixes the issue of not being able to edit content on the mobile viewport by not rendering the unpinnable sidebar on the mobile viewport.
Closes #71718
Why?
There are two types of sidebars.
Pinnable Sidebar
It can be accessed from the block toolbar or the comments button in the header. This sidebar has a close button.
Unpinnable Sidebar
Shown by default when the Post Sidebar is hidden. This sidebar doesn't have a close button:
The fundamental problem is that this unpinnable sidebar takes up the entire screen in mobile layouts and cannot be closed.
How?
Don't show the unpinnable sidebar on mobile viewports. Even without the unpinnable sidebar, there is still a way to access the comments sidebar from the mobile layout by clicking the Comment button on the block toolbar.
Testing Instructions
Narrow your browser and make sure you can always access the comments.
Screenshots or screencast
bc58c6076fee9635558f5220bab46b0f.mp4