You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR organizes block supports for the Accordion block family by adding typography and removing conflicting margin settings.
Why?
Missing typography controls in core/accordion and core/accordion-content.
margin support from core/accordion-header and core/accordion-panel conflicts with the parent block's gap settings.
How?
updated the supports object in the block.json files for the four accordion blocks to add typography and remove margin where appropriate, following the patterns used by other core blocks.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
đź‘‹ Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ritoban23! In case you missed it, we'd love to have you join us in our Slack community.
If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71801
This PR organizes block supports for the Accordion block family by adding typography and removing conflicting margin settings.
Why?
core/accordion
andcore/accordion-content
.margin
support fromcore/accordion-header
andcore/accordion-panel
conflicts with the parent block's gap settings.How?
updated the
supports
object in theblock.json
files for the four accordion blocks to addtypography
and removemargin
where appropriate, following the patterns used by other core blocks.