| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 09:45:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=372.280517,conversation_content-fragment;desc="conversation_content fragment";dur=794.932792,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=355.455098,nginx;desc="NGINX";dur=0.526431,glb;desc="GLB";dur=138.287516
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=C8Hd45gAF2xsqicHDsC%2FeXujV4TJ3tlEnOYXT8auZpOv6RarTFKPP9oBoGY228cQRbzQmfrGX9BVLv%2FnjWhM0n16pepGQcxOy%2B7quwOKISKvorRfVceTPV6t2DoGCJ8963JrgXIrRavjTSIgEpOmPIu6a4%2FC2raBZPL6CY1BF1mmkf7Mkix7NxBsqmpUKNcuWBNsns6f3cVK6Xf%2F4wbp0%2BuFMIoCh8LAIS07%2BfjRYGkeJFIthW1YnseUx4tdMBZ%2F1GfJ%2FzXpgj%2FCzw6pIF8hLg%3D%3D--kXscLSdQfPJxl6pP--qtPAlTxPprcJ0QJRyODDcQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1876376606.1760175954; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:45:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:45:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EBC6:123F70:54C59C:72543F:68EA2752
Accordion Block: hide "Add" button when multiple blocks are selected by R1shabh-Gupta · Pull Request #71750 · WordPress/gutenberg · GitHub
R1shabh-Gupta
requested review from
ajitbohra and
fabiankaegy
as code owners
September 19, 2025 06:09
t-hamano
added
[Type] Bug
An existing feature does not function as intended
[Block] Accordion
Affects the Accordion Block
labels
Sep 19, 2025
t-hamano
changed the title
fix: hide "Add" button when multiple blocks are selected
Accordion Block: hide "Add" button when multiple blocks are selected
Sep 19, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Accordion Block: hide "Add" button when multiple blocks are selected #71750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 2 commits into
WordPress:trunk
from
R1shabh-Gupta:fix/71739-accordion-conditional-add-button
Sep 19, 2025
Merged
Accordion Block: hide "Add" button when multiple blocks are selected #71750
t-hamano
merged 2 commits into
WordPress:trunk
from
R1shabh-Gupta:fix/71739-accordion-conditional-add-button
Sep 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1shabh-Gupta
requested review from
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
t-hamano
reviewed
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Can you use the isSelected prop instead? This prop should only be true when one block is selected. Example:
| { isSingleSelected && ( |
|
Thank you for the feedback! I’ve updated the PR accordingly. |
t-hamano
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
t-hamano
changed the title
|
@R1shabh-Gupta Sorry, can you remove the |
|
@R1shabh-Gupta, it looks like we already have a PR for that change. Please ignore our request. |
|
OK, I just merged this PR. Let's address the label issue in #71756. |
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 22, 2025
…ordPress#71750) * fix: hide "Add" button when multiple blocks are selected * refactor: use isSelected prop for Add button conditional rendering Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 22, 2025
…ordPress#71750) * fix: hide "Add" button when multiple blocks are selected * refactor: use isSelected prop for Add button conditional rendering Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Accordion
Affects the Accordion Block
[Type] Bug
An existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #71739
This PR hides the "Add" button in the Accordion block toolbar when multiple blocks are selected.
Why?
Currently, when you select multiple Accordion blocks and click the "Add" button in the toolbar, it only adds a new accordion content block to the first selected block. This is confusing behaviour because users expect the button to work on all selected blocks, or at least be hidden when multiple blocks are selected to avoid confusion.
How?
hasMultiSelectionselector from the block editor storehasMultiSelection()returns falseTesting Instructions
Screenshots or screencast
Before
Before.mov
After
After.mov