You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides the Icon Position setting when the Show icon toggle is turned off in the Accordion block.
Why?
When the Show icon setting is disabled, the Icon Position setting has no effect but was still visible in the inspector controls. This creates confusion for users as they see a setting that doesn't actually do anything when the icon is hidden.
How?
Added conditional rendering to only show the Icon Position setting when showIcon is true
Modified the Show icon toggle to reset iconPosition to the default value ('right') when the icon is disabled
Testing Instructions
Open the WordPress editor (post or page)
Insert an Accordion block
Select the Accordion block to open the inspector controls
In the Settings panel, you should see both "Show icon" and "Icon Position" settings
Toggle the "Show icon" setting to OFF
Verify that the "Icon Position" setting disappears from the panel
Toggle the "Show icon" setting back to ON
Verify that the "Icon Position" setting reappears and is set to "Right" (default)
Change the "Icon Position" to "Left", then toggle "Show icon" OFF and back ON
Verify that the position resets to "Right" when toggled back on
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71738
Hides the Icon Position setting when the Show icon toggle is turned off in the Accordion block.
Why?
When the Show icon setting is disabled, the Icon Position setting has no effect but was still visible in the inspector controls. This creates confusion for users as they see a setting that doesn't actually do anything when the icon is hidden.
How?
showIcon
istrue
iconPosition
to the default value ('right'
) when the icon is disabledTesting Instructions
Screenshots or screencast
Before
Before.mov
After
After.mov