CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Show open discussion indicators on posts page #71743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Show open discussion indicators on posts page #71743
Conversation
Questions
|
|
Thanks for the feedback @poojabhimani12 - I will update the PR. |
Here is a screencast of the current status. I noticed a few parts that still need fine tuning, for example the language when resolving a comment still says "Comment Approved", and the links that appear on hover are still incorrect (they include Spam and Trash). screencast.2025-09-22.14-08-39.mp4 |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…rdPress#71608) Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
…ordPress#71750) * fix: hide "Add" button when multiple blocks are selected * refactor: use isSelected prop for Add button conditional rendering Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Fixes WordPress#71740 Co-authored-by: Adi-ty <iamadisingh@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: theaminuli <theaminuldev@git.wordpress.org>
…s#71633) * Split controls into separate files * Add subterms control * Extract Empty Terms control * Change the default parent to false * Extract hierarchy control and make it render conditionally * Make the terms to show a radio * Modify the query depends on high level filters * Default to all terms when changing some attributes * Pass terms to show via context * Filter only children terms when subtree is chosen * Assign default query for subterms option * Add explanation to subterms option * Add a guard if terms is null * Add support for subtree on the frontend * Fix lint * Fix merge conflicts * Make code more defensive * Simplify the condition * Add end dot to comment * Fix lint * Rename function to match file name * Rename MaxTermsControls to MaxTermsControl to make it consistent with the rest of inspector controls * Fix duplicated taxonomies when showing all and hierarchical * Fix lint Co-authored-by: kmanijak <karolmanijak@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: Marc-pi <mdxfr@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
I have updated the PR with this approach. |
Thanks for sharing the visual. For me that looks pretty good, give or take the avatar fallbacks—but that's an entirely separate conversation 😅 Nice work. |
I don't think the avatars communicate enough information to be helpful in indicating that they are related to discussions[1]. If I didn't know about this feature, my first thought on seeing the avatars is that these are authors or contributors of the post rather than people engaged in a discussion around it. I just did an ask someone around me test and they thought it was people who have the post open (similar to the top of a google doc). Additionally, the avatars will be especially confusing when there are multiple people with default avatars (or with similar avatars). Going back to the label idea, I think that gives more flexibility in addition to more clear communication. I'm thinking it can communicate state/status of discusisons such as a label for:
[1] I'm using Discussions here for simplicity, the actual labels should depend on the outcome of #72014 |
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Thanks for the feedback @aaronjorbin - I also share some concern over what the avatars visually indicate. I would think of them more as presence indicators (eg. these people are currently editing the document) and raised that concern earlier in the thread - #71743 (comment). @jasmussen suggestion was adding a tooltip for the avatars, but of course that only shows on hover. Also, in case you missed it, I tried the label approach first, you can see what looks like here: #71743 (comment) Regarding New vs. Open discussion, this would require tracking more data than we currently have. We know if a post has unresolved comments, but not whether a specific user has opened the post since those comments were added. |
To summarize the options for resolving this ticket:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one commit to fix the PHPCS lint error. From a code perspective, this PR looks good, but we need to decide what the final design should be.
My other suggestion would be to treat unresolved comments as a kind of post status. This would mean introducing new logic into the ![]() However, this may be confusing on the other hand 😅 |
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Closes #71622
What?
Add Avatar indicators to posts that have unresolved threads: