| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 10:31:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=316.289308,conversation_content-fragment;desc="conversation_content fragment";dur=1487.617707,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=347.389113,nginx;desc="NGINX";dur=1.018405,glb;desc="GLB";dur=137.901414
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=D%2FtZ0qKiff6cM8AcQKuEPXRlTveVLoSqwjw6oEPOIs8rw5ebMTsWVxQ4MNkRfdlWriSaVpVJxqalwSi7o0qGz75fhf1ckAvLKn%2BJSIipdKbwVZdP26CcRuF3AnztCIRimN8195II57dpQyLtM26b9kBg9nS16t%2Baw5j7NxsuWuby2RPOOCWBhFRof57pU%2BONM3yj2PAI5%2FSWy2oUCoxzx%2B2T%2Bf48Oy%2FZAnKWIGcLIpIvKloDPIXvQiZpnAM%2BiTtv%2BYfP26dc016xZkJZjTTqDg%3D%3D--xWyIyeCsqAQgbm7j--%2Fdf%2BeV28f3aecvMBv09Q6A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.841643723.1760178700; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 10:31:40 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 10:31:40 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A9BC:3E2ABE:5A3FCD:793985:68EA320C
PostTypeSupportCheck: Handle support keys sub-features by Mamaduka · Pull Request #71723 · WordPress/gutenberg · GitHub
Mamaduka
added
[Type] Enhancement
A suggestion for improvement.
[Package] Editor
/packages/editor
labels
Sep 17, 2025
Mamaduka
force-pushed
the
try/post-type-support-check-nested-properties
branch
from
September 19, 2025 11:16
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
PostTypeSupportCheck: Handle support keys sub-features #71723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mamaduka
merged 2 commits into
trunk
from
try/post-type-support-check-nested-properties
Sep 19, 2025
Merged
PostTypeSupportCheck: Handle support keys sub-features #71723
Mamaduka
merged 2 commits into
trunk
from
try/post-type-support-check-nested-properties
Sep 19, 2025
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the PostTypeSupportCheck component to handle sub-feature support keys using dot notation (e.g., "editor.block-comments"). The component can now check for nested support properties in addition to top-level support keys.
- Adds a new
checkSupporthelper function to handle both top-level and sub-feature support checks - Updates the component to use the new helper function for support validation
- Adds comprehensive test coverage for the new sub-feature functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/editor/src/components/post-type-support-check/index.js | Implements the core sub-feature support logic with new helper function |
| packages/editor/src/components/post-type-support-check/test/index.js | Adds test cases for sub-feature support validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Sep 17, 2025
Comment on lines
+19
to
+22
| const [ subProperties ] = Array.isArray( supports[ topKey ] ) | ||
| ? supports[ topKey ] | ||
| : []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a comment here to mention the odd shape support value when using sub-features.
Example
{
"title": true,
"editor": true,
"author": true,
"test1": [
[
"block-comments"
]
],
"test2": [
{
"block-comments": true
}
],
}
|
Size Change: +61 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
adamsilverstein
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Mamaduka
force-pushed
the
try/post-type-support-check-nested-properties
branch
from
c5a0875 to
3dbee33
Compare
|
Thanks for testing, @adamsilverstein! I've updated the PR description to include more details. |
t-hamano
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Deep nesting is weird, but we need to maintain the current specification for backward compatibility 😅
|
Flaky tests detected in 3dbee33. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17856755771
|
1 task
adamsilverstein
added a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 22, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Related #71682 (comment).
Updates
PostTypeSupportCheckcomponent to handle support keys sub-feature checks.Note: Currently, it only supports one level of nesting for simplicity. Technically, we could support more complex paths, but sub-properties can have different shapes.
Why?
Some new editor features rely on these sub-properties.
Testing Instructions
PR has unit tests.
Testing Instructions for Keyboard
Same.