You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Add page button introduced in #71192 when button text labels are enabled.
The addition of "title" to ToolbarButton adds it as an aria-label to the underlying button, and aria-labels are output when text labels are enabled. Given the button has text, it doesn't need an aria-label.
This PR removes the aria-label, and also makes a small adjustment to text label styles so they don't take effect when the button has both icon and text.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in 3ccec97.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes Add page button introduced in #71192 when button text labels are enabled.
The addition of "title" to
ToolbarButton
adds it as an aria-label to the underlying button, and aria-labels are output when text labels are enabled. Given the button has text, it doesn't need an aria-label.This PR removes the aria-label, and also makes a small adjustment to text label styles so they don't take effect when the button has both icon and text.
Testing Instructions
"contentRole": true
to the Nav block supports (or follow the testing steps in Add Navigation Add Page Button Β #71192)