| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 19:01:51 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=566.149998,conversation_content-fragment;desc="conversation_content fragment";dur=1827.967555,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=529.377454,nginx;desc="NGINX";dur=0.851256,glb;desc="GLB";dur=138.023275
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=zofJ8EUcuBT%2F1xCMcJrsXjNjJye%2Fpnr2tdQ2syP4Ky1RvmEo4QwL%2B9Zi4MfXTPjxh0I5tK277EFbqM%2FSVz1iBr6ABX9AyKH8TMYmufPb1u58bIwYykgJ6JoAAr%2F6xRkSMjLc5pjJV5fzLES%2F5xM49ZtABRoVVFC7mUukGo9pL4HWaCPHqSbSn3DzteUehsPW2c3hw%2FQ%2BWucrJEE2Qw6eR6IWDEB0KbmaLj7r%2BkGR039aQjUjLQkc27mK4nPQcHyR1pouRNElihmf96IA6jX5zA%3D%3D--KKfPkdrW9Ou5%2BlLL--j9GT74lxEB8lWRuZEFuFfQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1324467594.1760122909; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 19:01:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 19:01:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BC68:547BC:36E6C:471A0:68E9581D
contentOnly Patterns experiment: Add Edit Contents button to block inspector and show 'Detach' block action by talldan · Pull Request #71653 · WordPress/gutenberg · GitHub
talldan
requested review from
aaronrobertshaw,
andrewserong,
getdave,
jeryj,
ramonjd and
tellthemachines
September 15, 2025 08:33
talldan
added
[Type] Experimental
Experimental feature or API.
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
labels
Sep 15, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
contentOnly Patterns experiment: Add Edit Contents button to block inspector and show 'Detach' block action #71653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e attribute to a block
talldan
requested review from
aaronrobertshaw,
andrewserong,
getdave,
jeryj,
ramonjd and
tellthemachines
talldan
added
[Type] Experimental
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +495 B (+0.03%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
talldan
commented
Sep 15, 2025
Comment on lines
+83
to
+85
| patternName: insertedPatternId, | ||
| // When a pattern is created for the first time the `categories` are missing. | ||
| // This is a known issue that needs to be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as adding the patternName, we should add a categories apparently.
The way categories works is hard for me to understand - sometimes the category id is added, sometimes the category name.
I can't figure out what categories property does, so for now I've not added it. I'll make a follow-up issue to add it consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a very old repressed memory that categories here need to handle both the "default" categories (ones with a name) and those created by the user which leverage a taxonomy and end up with IDs.
A quick search dug up these that might help shine a light on the situation:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the links, that'll help for sure! I'll make sure to add them to the issue I create.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is here - #71687
|
Flaky tests detected in 4175560. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17752508496
|
aaronrobertshaw
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @talldan 👍
This is working as advertised for me.
✅ Edit contents button in BlockCard is available and working as expected
✅ Detach block action for unsynced patterns is available and works
✅ Manage patterns block action for unsynced patterns is now available
Hides the 'Create pattern' block action for unsynced patterns
Fixes an issue where patternName isn't added to block metadata when the 'Create pattern' block action is used.
Fixes an issue where block editing modes were not recalculated when the patternName attribute is added or removed.
These additional tweaks and fixes make sense to me.
I'm happy to approve this but I'm also still getting my head around all the contentOnly pattern experiments so feel free to get a second opinion.
Comment on lines
+83
to
+85
| patternName: insertedPatternId, | ||
| // When a pattern is created for the first time the `categories` are missing. | ||
| // This is a known issue that needs to be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a very old repressed memory that categories here need to handle both the "default" categories (ones with a name) and those created by the user which leverage a taxonomy and end up with IDs.
A quick search dug up these that might help shine a light on the situation:
andrewserong
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing great for me, too, and the "Edit Contents" button really feels like it's starting to create a nice flow here IMO 👍
Comment on lines
85
to
87
| const isUnsyncedPattern = | ||
| blocks.length === 1 && | ||
| blocks?.[ 0 ]?.attributes?.metadata?.patternName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double-checking: we don't check for the experiment here, but I assume that's safe because the block would only have the patternName metadata if it had been added due to the experiment being added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patternName is also added in trunk, so it will also apply there. The code will hide the "Create pattern" option for blocks that are already marked as a pattern. My thinking is that it's a bit duplicative. On the other hand, in trunk users can change the blocks in the pattern, so they might want to save changes as a different pattern.
Maybe it's better behind the experiment, what do you think? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and added the experiment flag here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and added the experiment flag here.
Sounds good, I don't think it's a huge issue either way for this one, but one of the other good things about adding the flag is that it highlights the different bits of the feature for us to re-test before we stabilise / remove the flag.
Looking good to me!
ramonjd
reviewed
Sep 16, 2025
| break; | ||
| } | ||
| case 'UPDATE_BLOCK_ATTRIBUTES': { | ||
| // Handle unsynced patterns which indicate their contentOnly-ness via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contentOnly-ness
My favourite bit.
…when experiment is active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
[Type] Experimental
Experimental feature or API.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #71558
Part of #71517
Does the following when the contentOnly patterns experiment is active:
Does the following regardless of whether the experiment is active (they feel like good changes generally, but let me know if you think they should be part of the experiment):
patternNameisn't added to block metadata when the 'Create pattern' block action is used.patternNameattribute is added or removed.This ended up being more involved than initially expected, it required quite a few related changes.
Testing Instructions
First enable the experiment in Gutenberg > Experiments from wp admin:
contentOnlymode is now not active on the pattern contentscontentOnly.Screenshots or screencast
Kapture.2025-09-15.at.16.29.11.mp4