You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the displayed comment time in collaboration to show the correct time based on WordPress Installation.
Why?
Earlier, the display time had its timezone offset applied twice ie If WordPress installation is set to UTC and device is set to IST instead of showing the time in UTC, the displayed time was UTC - 530.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
[Feature] NotesPhase 3 of the Gutenberg roadmap around block commentingInternationalization (i18n)Issues or PRs related to internationalization efforts[Type] BugAn existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71650
This PR fixes the displayed comment time in collaboration to show the correct time based on WordPress Installation.
Why?
Earlier, the display time had its timezone offset applied twice ie If WordPress installation is set to UTC and device is set to IST instead of showing the time in UTC, the displayed time was UTC - 530.
How?
This PR addresses this by using
getDate
function to correctly get the date Object before applyingdateI18n
at packages/editor/src/components/collab-sidebar/comment-author-info.js#L57-L62Testing Instructions
Screenshots or screencast