| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 10:44:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=484.275739,conversation_content-fragment;desc="conversation_content fragment";dur=1269.674626,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=470.934513,nginx;desc="NGINX";dur=1.293583,glb;desc="GLB";dur=139.053491
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=srIOvM69ejorl%2Bgu4TTS42eH2kv6QtMUEEJ40C8PSbkyYW9qgh%2FAx%2BR6W3zlAt3tVr4yEzTcTNzV30NRuIiS6xWxb%2B6nGa2T15y6vjSmKJ8D7HkHZ%2BzXKZKwb1Qt9Sftm3hIOB79RB3zc0QoSOGsGnwvEpY8EOkij%2BuT%2FaiZ5FQAbkUmYU8Sa%2FXV4sgXfhNXpI20qn9tZXDJqVRkI%2BkGWXKlK8HtuPmaR4cRG9Y8uXygB76j77g41dRlZoZ5dnaPUeQMRGKdf%2BnKlzVrr%2Bvu8g%3D%3D--S%2BJMouaF%2FSjcit4p--nemgGGMPTe7NstWQQ00Seg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.105062144.1760179442; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 10:44:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 10:44:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B2EA:547BC:5C1FC9:7B81B0:68EA34F2
Add password field by heavyweight · Pull Request #71545 · WordPress/gutenberg · GitHub
heavyweight
force-pushed
the
add/password-field
branch
from
September 8, 2025 14:15
heavyweight
force-pushed
the
add/password-field
branch
from
September 8, 2025 14:21
oandregal
added
[Type] Enhancement
A suggestion for improvement.
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
labels
Sep 8, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add password field #71545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add password field #71545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
heavyweight
force-pushed
the
add/password-field
branch
from
7d5ae04 to
0aa6050
Compare
heavyweight
force-pushed
the
add/password-field
branch
from
0aa6050 to
66d1b4b
Compare
|
Thanks for working on this @heavyweight. Could you also update the validation story here to include the |
oandregal
reviewed
Sep 8, 2025
| }, [] ); | ||
|
|
||
| return ( | ||
| <ValidatedInputControl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this use the utility/validated-text.tsx component instead? I understand it just needs to accept a suffix. It'd be great if the utility was renamed to utils/validated-input.tsx as well (we forgot to that recently).
oandregal
reviewed
Sep 8, 2025
| render: ( { item, field }: DataViewRenderFieldProps< any > ) => { | ||
| return field.elements | ||
| ? renderFromElements( { item, field } ) | ||
| : '•'.repeat( field.getValue( { item } ).length ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can render a fixed number of dots instead of giving away the pass length?
oandregal
reviewed
Sep 8, 2025
| ? renderFromElements( { item, field } ) | ||
| : '•'.repeat( field.getValue( { item } ).length ); | ||
| }, | ||
| enableSorting: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should disable sorting by default, even though the field consumer can enable it.
oandregal
reviewed
Sep 8, 2025
| }, | ||
| enableSorting: true, | ||
| filterBy: { | ||
| defaultOperators: [ OPERATOR_IS_ANY, OPERATOR_IS_NONE ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, perhaps we shouldn't offer any filtering for password by default.
oandregal
added
[Type] Enhancement
oandregal
approved these changes
Sep 8, 2025
44 tasks
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Co-authored-by: heavyweight <kpapazov@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
[Type] Enhancement
A suggestion for improvement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Adds a new
passwordfield type to the DataViews package with show/hide toggle functionality.Why?
DataViews currently lacks a dedicated password field type for handling sensitive data. This field type is essential for forms that need to collect and display passwords.
How?
Field Type Definition (
packages/dataviews/src/field-types/password.tsx):FieldTypeDefinitionwith proper validation•) based on password lengthForm Control (
packages/dataviews/src/dataform-controls/password.tsx):seen/unseenicons for intuitive user experienceStory Integration (
packages/dataviews/src/field-types/stories/index.story.tsx):Testing Instructions
npm run storybook:devScreenshots or screencast