| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 07:35:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=383.236809,conversation_content-fragment;desc="conversation_content fragment";dur=873.911834,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=244.92265,nginx;desc="NGINX";dur=1.026048,glb;desc="GLB";dur=140.594945
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=TmbDP6Ud7Et3V823UfWR3sk6QcOXL5DVvPTTWeMvcWcBI%2B61Fu683AELAnn%2FvuAR5GjpOuj6LSXyVGlu%2FTf4D1uYhUkgKVLbYCuqpIPGTmXO7ZBOQ2q%2FZ%2FELlXsHeKz4i1p0%2Fkoa4dByec36sElAMtri6mbzllEJd94aeKqmDOUwkDiqdHg142a5Fpq%2FdfL2hRdXmZIImkLw0oKufPe0rUmU4uHTFle08bkrfpZeziRL%2FdnZdnxG4FtzpvzQS1sqPn1OVDiCzKqAnW%2BkCUq0xw%3D%3D--AhqgLyXhCAJ7W%2BcR--PkpoYPq5Z53p7%2BERK%2Bvvvw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1212327846.1760168138; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 07:35:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 07:35:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EA08:12A139:44A541:5E0E9A:68EA08CA
Add color field type and control to DataViews by jorgefilipecosta · Pull Request #71522 · WordPress/gutenberg · GitHub
jorgefilipecosta
requested review from
ajitbohra and
oandregal
as code owners
September 5, 2025 14:51
oandregal
added
the
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
label
Sep 8, 2025
jorgefilipecosta
force-pushed
the
fix/color-control-spacing-alignment
branch
from
September 8, 2025 11:16
jorgefilipecosta
force-pushed
the
fix/color-control-spacing-alignment
branch
from
September 8, 2025 11:35
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add color field type and control to DataViews #71522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ajitbohra and
oandregal
as code owners
oandregal
added
the
[Feature] DataViews
oandregal
reviewed
Sep 8, 2025
oandregal
reviewed
Sep 8, 2025
Comment on lines
+62
to
+67
| if ( | ||
| ! [ undefined, '', null ].includes( value ) && | ||
| ! colord( value ).isValid() | ||
| ) { | ||
| return __( 'Value must be a valid color.' ); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the color type to the validation story as well?
oandregal
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a couple of comments, other than that, it's ready. Thanks!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
force-pushed
the
fix/color-control-spacing-alignment
branch
from
0fa48f4 to
0b2d829
Compare
|
Size Change: +3.11 kB (+0.16%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
- Add new color field type with validation using colord library - Implement color control with text input and visual color picker - Support alpha channel colors (rgba, hsla) - Use proper WordPress component patterns with private APIs - Fix spacing and alignment issues for better visual integration - Add comprehensive Storybook stories for testing - Add colord dependency to dataviews package
Co-authored-by: André <583546+oandregal@users.noreply.github.com>
jorgefilipecosta
force-pushed
the
fix/color-control-spacing-alignment
branch
from
0b2d829 to
28bc9da
Compare
44 tasks
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] DataViews
Work surrounding upgrading and evolving views in the site editor and beyond
[Type] Enhancement
A suggestion for improvement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Adds a new
colorfield type and control to DataViews that allows users to input color values via text input and visual color picker.How
Screenshot
Testing
Dependencies
colorddependency to dataviews package (already used on other parts of gutenberg) for color validation and manipulation