| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:49:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=398.403126,conversation_content-fragment;desc="conversation_content fragment";dur=1342.995858,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=446.275665,nginx;desc="NGINX";dur=1.047398,glb;desc="GLB";dur=137.896312
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=5zjeuRbR1KEzKUZ8aajm8iAFUU0S85SCIo6oBwspmoYHFG6F9pmGzkm6lnQY8s7p5zzJI1PnjSxc3LBw5Rk0lkoUgxXUeDPt%2BG9g6Ra2olXQekrB0CAt%2FsFZ1DNstkyVH87szT33ICL%2FdLR2JE1kVMRP8fkWYELrZPR%2FY59Ume5TFbOZMiv1WWdsxstqRRrZBF1p8tR480lyKnz2s55RTRVCdasrhbdLFv%2B4%2FiV52TyZwTxWK7bRj%2BltT62pae1qMCWqxiaVUkD17EsL5K3DVQ%3D%3D--AbtR0HCWt%2BpMYHCu--9ZzGxGqxcfzWwKFTfLaCrQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1246310477.1760197754; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:49:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:49:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: ED2E:8CC4A:8270C7:AB8E74:68EA7C7A
Localize labels in getVisualTypeName() for link control search items by Adi-ty · Pull Request #71503 · WordPress/gutenberg · GitHub
getdave
added
[Type] Enhancement
A suggestion for improvement.
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
labels
Sep 5, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Localize labels in getVisualTypeName() for link control search items #71503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 5 commits into
WordPress:trunk
from
Adi-ty:fix/localize-link-control-search-item-labels
Sep 10, 2025
Merged
Localize labels in getVisualTypeName() for link control search items #71503
t-hamano
merged 5 commits into
WordPress:trunk
from
Adi-ty:fix/localize-link-control-search-item-labels
Sep 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
reviewed
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Very much appreciated.
Could we avoid changing the case of the labels in this PR? If we want to do that we can propose in a followup but it seems unrelated to the translation.
getdave
added
[Type] Enhancement
t-hamano
reviewed
Sep 6, 2025
packages/block-editor/src/components/link-control/search-item.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/search-item.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/link-control/test/index.js
Outdated
Show resolved
Hide resolved
Since we removed the |
getdave
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 👍
t-hamano
reviewed
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can't test it now, but once the Gutenberg plugin that includes this PR is released and each label is translated, the UI should also be localized.
t-hamano
approved these changes
Sep 10, 2025
talldan
pushed a commit
that referenced
this pull request
Sep 10, 2025
…71503) * Localize labels in getVisualTypeName() for link control search items Fixes #71492 * Update LinkControl tests to expect localized post type labels * Ensure localized lowercase labels in getVisualTypeName * Refactor LinkControl to use unified TYPES object for icons and labels * Capitalize labels in TYPES object and test Co-authored-by: Adi-ty <iamadisingh@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: dannyreaktiv <dannyreaktiv@git.wordpress.org>
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
…ordPress#71503) * Localize labels in getVisualTypeName() for link control search items Fixes WordPress#71492 * Update LinkControl tests to expect localized post type labels * Ensure localized lowercase labels in getVisualTypeName * Refactor LinkControl to use unified TYPES object for icons and labels * Capitalize labels in TYPES object and test Co-authored-by: Adi-ty <iamadisingh@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: dannyreaktiv <dannyreaktiv@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Type] Enhancement
A suggestion for improvement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #71492
Localizes the labels shown in link control search items by fixing the
getVisualTypeName()function to use proper translatable strings instead of raw post type slugs.Why?
The link control search items were showing raw post type slugs that weren't translatable. Inconsistent capitalization handled via CSS transforms
How?
Added
__()translation functions for all user-facing strings