You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents users from adding comments to empty blocks (unmodified default blocks) and the block inserter placeholder, addressing unexpected behavior in the collaborative commenting feature.
Why?
Currently, the block commenting feature allows users to add comments to empty paragraph blocks and the block inserter placeholder, which feels unexpected and unintuitive. When a user clicks into an empty block or the inserter area, they shouldn't be able to add comments since there's no actual content to comment on.
This issue was identified as part of the Block Commenting iteration for WordPress 6.9 and affects the user experience of the collaborative workflows feature.
How?
The fix adds a check in the AddComment component to detect unmodified default blocks using the existing isUnmodifiedDefaultBlock utility function from @wordpress/blocks. When an empty default block is selected, the comment form is not rendered, preventing users from adding comments to these blocks.
Key changes:
Import isUnmodifiedDefaultBlock from @wordpress/blocks
Add isEmptyDefaultBlock check in the useSelect hook
Prevent rendering the comment form when isEmptyDefaultBlock is true
Testing Instructions
Enable the comments experiment in Gutenberg
Create a new post or page
Add a paragraph block with some content
Add a comment to the paragraph block (this should work normally)
Click on an empty paragraph block or the block inserter placeholder
Verify that no comment form appears in the collaboration sidebar
Try clicking on other content blocks to ensure commenting still works normally
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
[Feature] NotesPhase 3 of the Gutenberg roadmap around block commenting[Type] BugAn existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71496
Prevents users from adding comments to empty blocks (unmodified default blocks) and the block inserter placeholder, addressing unexpected behavior in the collaborative commenting feature.
Why?
Currently, the block commenting feature allows users to add comments to empty paragraph blocks and the block inserter placeholder, which feels unexpected and unintuitive. When a user clicks into an empty block or the inserter area, they shouldn't be able to add comments since there's no actual content to comment on.
This issue was identified as part of the Block Commenting iteration for WordPress 6.9 and affects the user experience of the collaborative workflows feature.
How?
The fix adds a check in the
AddComment
component to detect unmodified default blocks using the existingisUnmodifiedDefaultBlock
utility function from@wordpress/blocks
. When an empty default block is selected, the comment form is not rendered, preventing users from adding comments to these blocks.Key changes:
isUnmodifiedDefaultBlock
from@wordpress/blocks
isEmptyDefaultBlock
check in theuseSelect
hookisEmptyDefaultBlock
is trueTesting Instructions
Screenshots or screencast
Before
Before.mov
After
After.mov