You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the button text from 'Add page' to 'Create page' in the Navigation Link UI.
Why
As noted in the review comment, 'Create' makes more sense here than 'Add' - 'Adding' is the process of putting the link into the navigation, while 'Creating' is the process of actually making the entity.
How
Simple text change in the button label from __( 'Add page' ) to __( 'Create page' ) in the LinkUI component.
Testing
Open the Navigation Link block
Click the button to create a new page
Verify the button now shows 'Create page' instead of 'Add page'
Follow-up to #71188 addressing review feedback from @scruffian.
The button text is changed from 'Add page' to 'Create page' to better
reflect the action being performed - creating a new page entity rather
than just adding an existing page to the navigation.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in ee2c17f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #71188 addressing review feedback from @scruffian.
Changes the button text from 'Add page' to 'Create page' in the Navigation Link UI.
Why
As noted in the review comment, 'Create' makes more sense here than 'Add' - 'Adding' is the process of putting the link into the navigation, while 'Creating' is the process of actually making the entity.
How
Simple text change in the button label from
__( 'Add page' )
to__( 'Create page' )
in the LinkUI component.Testing
Screenshots