| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 21:23:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=575.512626,conversation_content-fragment;desc="conversation_content fragment";dur=761.521209,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=594.772781,nginx;desc="NGINX";dur=0.852016,glb;desc="GLB";dur=137.767063
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=7NiX1mlhId2QErhcnGlsWSK45AGNejz8Bkpi3W5WBRhTjVRD3wo0ZUszEFDPMaFttv1TwRPxuO0X3cMlHoC6wmlmml8h9RSea7wQ%2FJs%2B1Ps9rJRTUJfkQBiUTxxFesoUWCNurbwZYsBYvWUgCoX4NqRXgwOyknTYKch1jhnXgvz2CEar8ibqhDoVQdInl0iZvh%2F1J01tLTgnbHG0jXVTRzGg4sPAvGhgMS5pqsnFaO2GT8pQ8kEQVXW42vfWZqPBkvf1eJjq%2BYLutILTVH9pUA%3D%3D--vI06LIrpcenbhiyi--eSCaTc6%2FNZ0UxmUuYqdvjg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.325240951.1760131382; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:23:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:23:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B5CE:AD439:EFEF7:149A91:68E97936
refactor: remove unnecessary fields from accordion block.json files by R1shabh-Gupta · Pull Request #71441 · WordPress/gutenberg · GitHub
R1shabh-Gupta
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
September 1, 2025 10:45
Mamaduka
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Block] Accordion
Affects the Accordion Block
labels
Sep 1, 2025
t-hamano
added
the
props-bot
Manually triggers Props Bot to ensure the list of props is up to date.
label
Sep 2, 2025
github-actions
bot
removed
the
props-bot
Manually triggers Props Bot to ensure the list of props is up to date.
label
Sep 2, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
refactor: remove unnecessary fields from accordion block.json files #71441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 1 commit into
WordPress:trunk
from
R1shabh-Gupta:fix/71434-accordion-remove-unnecessary-fields
Sep 2, 2025
Merged
refactor: remove unnecessary fields from accordion block.json files #71441
t-hamano
merged 1 commit into
WordPress:trunk
from
R1shabh-Gupta:fix/71434-accordion-remove-unnecessary-fields
Sep 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1shabh-Gupta
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @dibyajit1234. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Code Quality
shail-mehta
approved these changes
Sep 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMđź‘Ť
t-hamano
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
t-hamano
added
the
props-bot
github-actions
bot
removed
the
props-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Accordion
Affects the Accordion Block
[Type] Code Quality
Issues or PRs that relate to code quality
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #71434
Removes unnecessary and invalid fields from accordion block.json files to clean up the block definitions and improve code quality.
Why?
The accordion blocks contained several unnecessary fields that were either unused, invalid:
This cleanup improves maintainability and reduces confusion for developers working with these blocks.
How?
The following fields were removed from the accordion block.json files:
Accordion block (
core/accordion):allowedBlocksattributeAccordion Content block (
core/accordion-content):"version": "0.1.0"fieldsupports.alignAccordion Header block (
core/accordion-header):"version": "0.1.0"fieldsupports.borderAccordion Panel block (
core/accordion-panel):"version": "0.1.0"fieldsupports.border