You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in def1ad5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
The reason will be displayed to describe this comment to others. Learn more.
It would have been nice to ensure this was handled in git as a move instead of a separate add/delete, as it severs the git history and makes rebasing PRs much harder.
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe it was related to the way the PR was squashed into trunk rather than something you did. I see in the first commit it was handled as a move - 847bf62
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oandregal
added
the
[Feature] DataViews
What?
Update the existing Field Types story so that each field type (text, integer, email, array, etc.) displays:
{id: '…', type: '…' }.{ id: '', type: '...', elements: [ ... ] }.{ id: '…', type: '…', Edit: 'checkbox' }.This affects both DataForm (the control displayed in regular layout) and DataViews (the control used for filtering).
Why?
So that we have documentation for people onboarding into DataForm/DataViews development (either contributing or consuming the libraries).
How
Editcontrol for the whole story, so that users can switch to using a different Edit control and see the effects it causes.Testing Instructions
Run the storybook locally (
npm install && npm run storybook:dev) and visit "DatViews > Field Types" story.