You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the comment box has a fixed size. Instead, the textarea should scale to the contained comment text with a minimum size similar to the current display.
How?
Use the TextareaAutosize component.
Testing Instructions
make sure inline commenting experiment is enabled
leave a comment that is much larger than the input box
expected results:
The text area should expand to show the full text.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Yeah, I noticed. oops, not sure what happened! I'm going back to my usual pattern of merging trunk until I figure that out. I was just asking you about it in the other thread.
@Mamaduka I think what happened is I was resolving conflicts when rebasing on trunk, then inadvertently pushed the branch while still in the unresolved state. To fix the issue I aborted the rebase, did the rebase again completing it this time and force pushed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes the comment input resize to the contained text.
Closes: #71425
Why?
Currently the comment box has a fixed size. Instead, the textarea should scale to the contained comment text with a minimum size similar to the current display.
How?
Use the TextareaAutosize component.
Testing Instructions
expected results:
The text area should expand to show the full text.
Testing Instructions for Keyboard
same