You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR filters out resolved comments from the unpinned collaboration sidebar to declutter the editor display while keeping them visible in the pinned sidebar for complete comment history.
Why?
When comments are resolved, they should disappear from the default unpinned view to reduce visual clutter and help editors focus on active, unresolved comments that need attention. Previously, both resolved and unresolved comments were shown in all sidebar modes.
How?
Added filtering logic to exclude comments with status === 'approved' from the unpinned sidebar
Preserved all comments (resolved + unresolved) in the pinned sidebar for full history access
Refactored variable names for clarity (sortedThreads β unresolvedSortedThreads)
Testing Instructions
Open the Gutenberg editor with a post or page
Add some blocks and create comments on them
Resolve one or more comments by clicking the "Resolve" button (checkmark icon)
Open the unpinned collaboration sidebar
Verify that resolved comments do not appear in the unpinned sidebar
Open the pinned collaboration sidebar
Verify that all comments (resolved + unresolved) appear in the sidebar
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
[Feature] NotesPhase 3 of the Gutenberg roadmap around block commenting[Type] BugAn existing feature does not function as intended
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71394
This PR filters out resolved comments from the unpinned collaboration sidebar to declutter the editor display while keeping them visible in the pinned sidebar for complete comment history.
Why?
When comments are resolved, they should disappear from the default unpinned view to reduce visual clutter and help editors focus on active, unresolved comments that need attention. Previously, both resolved and unresolved comments were shown in all sidebar modes.
How?
status === 'approved'
from the unpinned sidebarsortedThreads
βunresolvedSortedThreads
)Testing Instructions
Screenshots or screencast
Before
Before.mov
After
After.mov