You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the issue that randomization in the Gallery Block doesn't work when Lightbox is enabled.
Why?
We introduced a functionality to randomize images inside the Gallery block in #58733. I realized that the regular expression doesn't work if the provided HTML contains line breaks.
For example, when the lightbox is disabled, the rendered HTML is the following:
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
The reason will be displayed to describe this comment to others. Learn more.
This is working as expected for me with no regressions. I checked PHP logs as well.
I noticed there are no PHP unit tests for block_core_gallery_render(). I guess it would be good to have coverage for this one day, but for this specific case (interactivity API) it might be more appropriate to extend gallery.spec.js E2E tests.
Seeing as this is fixing a bug and there are no existing tests, let's get the bugfix in at least.
Flaky tests detected in ed8f9de.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
[Block] GalleryAffects the Gallery Block - used to display groups of images[Type] BugAn existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reclose #65120
See: #65120 (comment)
What?
This PR fixes the issue that randomization in the Gallery Block doesn't work when Lightbox is enabled.
Why?
We introduced a functionality to randomize images inside the Gallery block in #58733. I realized that the regular expression doesn't work if the provided HTML contains line breaks.
For example, when the lightbox is disabled, the rendered HTML is the following:
On the other hand, when the lightbox is enabled, the image block has the button element, and there are a lot of line breaks and tabs:
Details
How?
Uses the dotall flag (
s
) to make.
match including newline characters.Ref: PHP: Possible modifiers in regex patterns - Manual
Testing Instructions
Screenshots or screencast
fed2cb03887e7786e0bf002420ac7cda.mp4