CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Editor: Try displaying intermediate results for hierarchical terms #71402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/editor/src/components/post-taxonomies/hierarchical-term-selector.js
Show resolved
Hide resolved
Size Change: +73 B (0%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
fa4e220
to
2936006
Compare
Flaky tests detected in 2936006. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17376205938
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @websupporter, @Widhy980, @ActionCoding, @MartinHlavna, @SuzuKube, @psokolovs, @drawcard, @amrutadotorg, @vijayrnathan, @zaidiseed, @gwwar, @jfdialogs, @bozzmedia, @nickstarkloff, @Blastbeater, @cherrygot-personal, @simonefontana, @apatwary12, @tecnogaming. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2936006
to
b475aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach works very well in my testing:
3cc06f9ad4c0ad2fc9549f779f817e23.mp4
I'm curious to see if this approach can be adopted for other queries with per_page: -1
.
packages/editor/src/components/post-taxonomies/hierarchical-term-selector.js
Outdated
Show resolved
Hide resolved
b475aa6
to
2b6b96d
Compare
Thanks for the review, @t-hamano! |
Okay, let's give this a try. |
…ordPress#71402) Unlinked contributors: designsimply, websupporter, Widhy980, ActionCoding, MartinHlavna, SuzuKube, psokolovs, drawcard, amrutadotorg, vijayrnathan, zaidiseed, gwwar, jfdialogs, bozzmedia, nickstarkloff, Blastbeater, cherrygot-personal, simonefontana, apatwary12, tecnogaming. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: danielbachhuber <danielbachhuber@git.wordpress.org> Co-authored-by: oxyc <scholdstrom@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org> Co-authored-by: torounit <toro_unit@git.wordpress.org> Co-authored-by: T4ngml <schwipps@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: jhmonroe <jhmonroe@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
What?
Closes #10169.
Previous work #29393.
Depends on #71401.
PR updates the query in the
HierarchicalTermSelector
component to start displaying intermediate results as it fetches all terms. The search and "create new term" fields aren't displayed while fetching is still in progress.Why?
Improves the perceived performance of the hierarchical terms panel by starting rendering it early. Waiting for the full, unbound query to finish can take a couple of seconds, depending on the number of terms.
How?
This is possible thanks to the new private
RECEIVE_INTERMEDIATE_RESULTS
query option (#66713).Testing Instructions.
wp term generate category --count=5000 --max_depth=3
.Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-08-29.at.15.10.27.mp4