You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
mirka
changed the title
ValidatedFormControls: Fix Sass var handling for red color
Validated form controls: Fix Sass var handling for red color
Sep 3, 2025
Flaky tests detected in 9a81db0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
Is there a lint rule that could help prevent these kinds of issues? I wonder if dollar-variable-no-missing-interpolation would do it? (if it's not already enabled)
Is there a lint rule that could help prevent these kinds of issues? I wonder if dollar-variable-no-missing-interpolation would do it? (if it's not already enabled)
Hmm, I didn't think of that! Would be nice if there was a quick automated check. But that dollar-variable-no-missing-interpolation at least, has this caveat:
This rule can only check for variables that are defined inside the same file where they are used.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes Sass variable handling for the red color in validated form controls.
Why?
They were not properly referencing the Sass color variable for red, rendering the
$alert-red
string itself in the resulting stylesheet.How?
Updates the Sass import/usage to properly reference the
$alert-red
variable.Testing Instructions
npm run storybook:dev
and go to the story forValidatedInputControl
.Screenshots or screencast