I might be mistaken, but I thought we shouldn't use different labels when a button has an actual text label, from an a11y perspective.

cc @joedolson, @t-hamano

we shouldn't use different labels when a button has an actual text label, from an a11y perspective.

This is how I understand it too. I think we should remove the label prop (aria-label),

Ah, I agree, I don't think we should have the label here at all. I thought I used a pattern I found in another block, but the only other example I can see is the Gallery block, which just uses "Add" as the button text with no label. Will spin up a PR with a fix!

Or we could do that as part of #71750

I see, we'll address it in #71750

PR here: #71756

I see, we'll address it in #71750

Ah sorry, didn't see these comments until after creating the PR 😅

We can do separate PRs. No problem.

Yes. If the context of the button is clear and it has visible text, it shouldn't also have a label prop. Thanks for catching this!