| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 18:26:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=490.936891,conversation_content-fragment;desc="conversation_content fragment";dur=602.298778,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=303.140196,nginx;desc="NGINX";dur=0.895104,glb;desc="GLB";dur=139.094201
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nkMZmrr52mxigGL02VwTvPn8WhA3gmVhqdt2hf5tyDh3mba0OQZ99ECFF4fWeF%2FLVgm8nD4pTMPCDlw3ltj7XbHbPj8ZqLdo6dCkuUqxNDVuTUh2%2BPlMSsUVoMlLpd95fAoCQ3Gt4OaWWz7O77%2FNwkES%2FcZrjcApz0QHjljgBGytk5bqWdR95rYTZaEI9kY%2BRttfn7mLN5Pj3VfUuqa6CpPcBFlwZv5BvNicXFqBGMLS%2B%2Bup7M3UFCP11lyu5ozCP33GOlqfF5tXxOPjk17VFw%3D%3D--M0%2BLYBmN9rI99BhW--qGRmaYylEgtQ80kEfFxRvA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.922717239.1760207171; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 18:26:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 18:26:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C41A:14CD9D:95B77E:C3D494:68EAA143
Block Comments: Make "n more replies" text clickable for accessibility by R1shabh-Gupta · Pull Request #71387 · WordPress/gutenberg · GitHub
t-hamano
added
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Needs Design Feedback
Needs general design feedback.
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
labels
Aug 29, 2025
t-hamano
added
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
and removed
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
labels
Oct 4, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Comments: Make "n more replies" text clickable for accessibility #71387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 2 commits into
WordPress:trunk
from
R1shabh-Gupta:fix/71249-clickable-more-replies-button
Sep 16, 2025
Merged
Block Comments: Make "n more replies" text clickable for accessibility #71387
t-hamano
merged 2 commits into
WordPress:trunk
from
R1shabh-Gupta:fix/71249-clickable-more-replies-button
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Focus] Accessibility (a11y)
6 tasks
t-hamano
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review!
Almost looks good, but I believe we can simplify the Button:
- No need to add
aria-labelbecause the button has visible text. - Since this button disappears when clicked, I don't think
aria-expanded=trueis necessary.
Taking this into consideration, it should be possible to simplify it as shown below:
<Button
__next40pxDefaultSize
variant="link"
className="editor-collab-sidebar-panel__show-more-reply"
onClick={ () => setFocusThread( thread.id ) }
>
{ sprintf(
// translators: %s: number of replies.
_x( '%s more replies', 'Show replies button' ),
thread?.reply?.length
) }
</Button>Furthermore, this padding should no longer be necessary:
| padding: 0; |
@WordPress/gutenberg-design, Note that this PR changes the appearance of the "n more replies" text. Any feedback is welcome.
| Before | After |
|---|---|
 |
 |
t-hamano
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! If there is any design feedback, let's address it as a follow-up.
|
Looks good. I believe the latest design for that particular type of link is actually this: 
Which isn't a blocker at all, we can certainly come back to this, even revisit it. Thanks for keeping on this! |
|
@jasmussen Thanks for the feedback! Let's apply that design as a follow-up PR. P.S. We're currently working hard to get the Block Commenting ready for shipping in 6.9. If you discover any issues from the design perspective, please let us know, and we'll address them 🙏 |
|
FYI that I created #71774 to follow-up on that design update, thanks for flagging @jasmussen! |
t-hamano
added
[Feature] Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Needs Design Feedback
Needs general design feedback.
[Type] Bug
An existing feature does not function as intended
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
See #71249
Converts the static "n more replies" text in block comments to a clickable, keyboard-accessible button that expands hidden comment replies.
Why?
The block comments feature currently displays "X more replies" as static text when there are many replies to a comment. Users found it unintuitive that they needed to click elsewhere on the comment thread (or use the "Select an action" menu) to expand and view these hidden replies. This creates accessibility barriers for keyboard and screen reader users who cannot easily discover how to access the additional replies.
How?
VStackelement containing "n more replies" text with aButtoncomponentaria-expanded="false", descriptivearia-label)variant="link"styling to maintain visual consistency while making it clearly interactivesetFocusThread()functionality that was previously only available through clicking elsewhere on the comment threadTesting Instructions
Testing Instructions for Keyboard
Tabkey to navigate through the comment sidebarEnterorSpacewhile the button is focusedScreenshots or screencast
Before
Before.mov
After
After.mov