You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We re-enable the storybook smoke test, but somehow, the CI started to fail again with the following error:
Details
Run npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"npx http-server ./storybook/build --port 50240 --silent" \
"npx wait-on tcp:127.0.0.1:50240 && \
NODE_PATH=./node_modules \
npx --package=@storybook/test-runner@0.22.1 -- \
test-storybook --url https://localhost:50240 --config-dir ./storybook"
shell: /usr/bin/bash -e {0}
[SB] npm warn exec The following package was not found and will be installed: http-server@14.1.1
[TEST] npm warn exec The following package was not found and will be installed: @storybook/test-runner@0.22.1
[TEST] npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
[TEST] npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
[TEST] npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
[SB] (node:6758) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
[SB] (Use `node --trace-deprecation ...` to show where the warning was created)
[TEST] Test Suites: 0 of 157 total
[TEST] Tests: 0 total
[TEST] Snapshots: 0 total
[TEST] Time: 0.216 s
[TEST] Ran all test suites.
[TEST] Error: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1187/chrome-linux/headless_shell
[TEST] ╔═════════════════════════════════════════════════════════════════════════╗
[TEST] ║ Looks like Playwright Test or Playwright was just installed or updated. ║
[TEST] ║ Please run the following command to download new browsers: ║
[TEST] ║ ║
[TEST] ║ npx playwright install ║
[TEST] ║ ║
[TEST] ║ <3 Playwright Team ║
[TEST] ╚═════════════════════════════════════════════════════════════════════════╝ Failed to launch browser.
[TEST] at executablePathOrDie (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/server/registry/index.js:517:15)
[TEST] at Object.executablePathOrDie (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/server/registry/index.js:548:45)
[TEST] at Chromium._prepareToLaunch (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/server/browserType.js:184:39)
[TEST] at async Chromium._launchProcess (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/server/browserType.js:196:22)
[TEST] at async Chromium._innerLaunch (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/server/browserType.js:112:70)
[TEST] at async Chromium._innerLaunchWithRetries (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/server/browserType.js:99:14)
[TEST] at async /home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/browserServerImpl.js:77:18
[TEST] at async ProgressController.run (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/server/progress.js:78:22)
[TEST] at async BrowserServerLauncherImpl.launchServer (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/browserServerImpl.js:68:17)
[TEST] at async BrowserType.launchServer (/home/runner/.npm/_npx/8cbbe221a9f534f3/node_modules/playwright-core/lib/client/browserType.js:73:12)
[TEST] npx wait-on tcp:127.0.0.1:50240 && NODE_PATH=./node_modules npx --package=@storybook/test-runner@0.22.1 -- test-storybook --url https://localhost:50240 --config-dir ./storybook exited with code 1
--> Sending SIGTERM to other processes..
[SB] npx http-server ./storybook/build --port 50240 --silent exited with code null
Error: Process completed with exit code 1.
The CI failures started around the same time as the new Playwright v1.55.0 was released, so I'm sure that the Playwright update is affecting us.
Why? How?
I believe we pinned all libraries to local versions with this PR, but maybe I missed something. Updating the Playwright version may solve the problem, but it won't be a fundamental solution.
I'm testing what happens if we explicitly install Chromium: #71284
As this comment says, the underlying problem may be that the Playwright version, and therefore the Chromium version, is different.
Installing the test runner first seems to resolve the Chromium version differences.
Note: In the trunk branch, the Playwright version has been updated to 1.55, so this issue does not occur (See: #71285). The purpose of this PR is to attempt to fix the fundamental problem, and the Playwright version in this PR is still 1.54.2.
Flaky tests detected in 7127ab8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
StorybookStorybook and its stories for components[Type] Automated TestingTesting infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We re-enable the storybook smoke test, but somehow, the CI started to fail again with the following error:
Details
The CI failures started around the same time as the new Playwright v1.55.0 was released, so I'm sure that the Playwright update is affecting us.
Why? How?
I believe we pinned all libraries to local versions with this PR, but maybe I missed something. Updating the Playwright version may solve the problem, but it won't be a fundamental solution.
I'm testing what happens if we explicitly install Chromium: #71284As this comment says, the underlying problem may be that the Playwright version, and therefore the Chromium version, is different.
Installing the test runner first seems to resolve the Chromium version differences.
Note: In the trunk branch, the Playwright version has been updated to 1.55, so this issue does not occur (See: #71285). The purpose of this PR is to attempt to fix the fundamental problem, and the Playwright version in this PR is still 1.54.2.