| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 10:33:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=325.734125,conversation_content-fragment;desc="conversation_content fragment";dur=1450.538033,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=393.38137,nginx;desc="NGINX";dur=0.938537,glb;desc="GLB";dur=138.625639
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=4qmqEGMBb2UpsTbMux5foYTlVTIxjbt6TGZcUZsm%2BU7Pqazbk0dnppNCr4ck3QeDS21j4BQPCo09jMIjvp%2FmR9AAvmmbBeA%2F2qOK66Bv8XMME%2B2Oono9XoU4lrQnV4sPUJvuOshXVpbELr%2FbSzh%2Bk60j2Dk8lHxpE0SZgpCHV9iU6VfUQ6%2FOR61PDgXemRaxw9h4VDWn6O66cwZ3OgX1%2FaxPZAhW1z1IOmKMHk9shhyeOwjcKC%2FTucPLM4YF8tDKUwwdP%2BpDOhHyYVDcUOVXow%3D%3D--uALsM9Bz2qpsltkO--iiEBYHMn7ZEZCZmP9xCQPA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1415065695.1760178783; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 10:33:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 10:33:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B326:366CA0:5E35E3:7DD5DE:68EA325F
Command Palette: Enqueue assets globally by t-hamano · Pull Request #71264 · WordPress/gutenberg · GitHub
t-hamano
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Feature] Command Palette
labels
Aug 20, 2025
t-hamano
changed the title
[WIP] Command Palette: Enqueue assets globally
Command Palette: Enqueue assets globally
Aug 20, 2025
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
Aug 25, 2025
t-hamano
moved this from 🔎 Needs Review
to 🎯 Needs Core Commit
in WordPress 6.9 Editor Tasks
Aug 25, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Command Palette: Enqueue assets globally #71264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
t-hamano
commented
Aug 20, 2025
Comment on lines
-94
to
-104
| add_settings_field( | ||
| 'gutenberg-command-palette-everywhere', | ||
| __( 'Command Palette: enable everywhere', 'gutenberg' ), | ||
| 'gutenberg_display_experiment_field', | ||
| 'gutenberg-experiments', | ||
| 'gutenberg_experiments_section', | ||
| array( | ||
| 'label' => __( 'Enables the Command Palette everywhere in the admin dashboard.', 'gutenberg' ), | ||
| 'id' => 'gutenberg-command-palette-everywhere', | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setting does nothing anymore, but I forgot to remove it 😅
|
Size Change: -53 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in d8ecc4b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17143369042
|
youknowriad
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great for me. I don't see any issues.
One thing I noticed is that I would love if we do some kind of audit/unification of all the navigation commands. Maybe all of them should be "go to something" and work in all screens. Right now it's a bit inconsistent. I think we use "open something" a bit more but sometimes we do nothing like just "styles"...
|
I forgot to delete the
Does this mean that navigation-related commands currently in the |
That sounds like a good approach to me, also unifying labels... |
I see, I'd like to submit an issue to address that later 👍 |
|
I'd like to add this PR to the 6.9 Editor Tasks board so that we don't forget to commit the core patch in 6.9 Beta 1 release. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
t-hamano
moved this from 🔎 Needs Review
to 🎯 Needs Core Commit
in WordPress 6.9 Editor Tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
This PR removes the core command initialization and registration code from the
edit-postandedit-sitepackages and enqueues command-related assets globally.Why?
We need to eliminate the Post Editor and Site Editor-specific processing and register commands with one code.
How?
@wordpress/edit-postand@wordpress/edit-site:CommandMenucomponent and the core commands registration process@wordpress/core-commandsdependencyTesting Instructions
There is absolutely no change in behaviour. Confirm that all commands work correctly in the post editor, site editor, and all admin pages.