The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yashjawale <yashjawale@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joemcgill the undo icon was just an implementation decision

Yeah moving the UI to DropdownMenu would make more sense, as its more of a secondary action.
I also had a look at other similar UIs & it aligns with approach used by Google Docs

Updated to move Reopen option inside DropdownMenu component instead

Options displayed:
For Unresolved comments -> Edit & Delete
For Resolved comments -> Delete & Reopen

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yashjawale <yashjawale@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This is looking good @yashjawale - thanks for working on this and posting the screencasts. Some feedback (see also my comment on the issue):

• The "resolve comment" button should probably go away for resolved comments.
• How about adding a comment field that also re-opens the comment similar to Google Docs? this seems like a very natural flow for users.
• What do you think about removing the confirmation Dialog for resolving a comment? Now that comments can be un-resolved, it feels excessive and a bit disruptive.

Updates to the PR...

• Changed "Comment reopened successfully" to "Comment reopened" for snackbar content
• Removed confirmation dialogs for comment resolve/approve flow
• Shows a InputControl beneath resolved comment which helps user to reply & reopen a thread in one action

Thanks for the screencast @yashjawale - functionally that looks great! I will give it a test and a code review soon.

I noticed in your screencast and in my testing that it is possible to leave a comment on an empty block. This behavior feels a little buggy to me, I will open a separate issue to discuss this with the wider group.

One other odd behavior worth discussing more that I saw was splitting a text block with a comment (by hitting enter) makes that comment apply to both blocks. It should probably only apply to the first block. This issue could still happen text fragment commenting - by hitting enter in the middle of a commented string.

Yes I'm able to replicate the behavior of splitting the text block on my side too
The ideal behavior in this case will probably need more discussion, as some might expect the comment to apply to both as the text in new line was part of the same content which was commented on. While others may favor to keep comment attached to initial block.

imo keeping the comment to just first block makes more sense

imo keeping the comment to just first block makes more sense

I agree, but could be swayed either way. I left a comment on the parent issue to start.

Updated ✅