| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Display names for Context providers #71208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
im3dabasia
requested review from
DAreRodz,
adamsilverstein,
ajitbohra,
ellatrix,
gziolo,
luisherranz,
nerrad and
oandregal
as code owners
im3dabasia
added
Developer Experience
|
@im3dabasia, can you include before and after screenshots from React DevTools? |
packages/interactivity/src/hooks.tsx
Outdated
|
|
||
| // Main context. | ||
| const context = createContext< any >( { client: {}, server: {} } ); | ||
| context.displayName = 'InteractivityContext'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a Preact context, not a React one, so I believe it's not needed in this PR.
|
Thanks @Mamaduka for the review. Before
After
|
|
@im3dabasia, could you add the changelog entries and rebase this branch? |
im3dabasia
force-pushed
the
try/add-context-names
branch
from
512d33f to
81d6c76
Compare
im3dabasia
added
props-bot
Mamaduka
added
the
props-bot
|
Not sure why the Props bot is failing. It's passing on other PRs. Should we try another rebase? |
im3dabasia
force-pushed
the
try/add-context-names
branch
from
81d6c76 to
841df2f
Compare
|
Sorry for the delay, @Mamaduka , I rebased the PR but still the Props bot is failing 😢 |
Mamaduka
removed
the
props-bot
|
Thanks, @im3dabasia! That's odd. @desrosj, any ideas why this might be happening? |
|
Interesting edge case! When Props Bot runs, it collects contributors from the PR itself and any linked issues. It looks like the original reporter for #48231 has chosen to delete their GitHub account, so the I will try to get this fixed later today. |
|
Thanks, @desrosj! Here's another similar case, which was caused by the "Ghost" account comment on the issue - https://github.com/WordPress/gutenberg/actions/runs/17322263480/job/49178020354?pr=71402. |
desrosj
added
the
props-bot
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. At least one To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
removed
the
props-bot
|
Looks like the fix from WordPress/props-bot-action#198 is working! |
|
Thank you, @desrosj! @im3dabasia, could you rebase (hopefully) one last time and resolve merge conflicts? Then it should be good to merge. P.S. Failing e2e test was also resolved via WordPress/wordpress-develop#9671. |
im3dabasia
force-pushed
the
try/add-context-names
branch
from
841df2f to
168a66c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @im3dabasia!
Labels
4 participants
What?
Closes #48231
Adds displayName to all Context providers in the block editor.
Why?
Makes it easier to identify Context providers in React Dev Tools, improving debugging and developer experience.
How?
Set displayName for each Context instance across the codebase.
Testing Instructions