| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:45:26 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=376.891419,conversation_content-fragment;desc="conversation_content fragment";dur=1030.437656,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=430.472241,nginx;desc="NGINX";dur=0.770522,glb;desc="GLB";dur=138.492527
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=YYHyCcScuSXF4YJ4B5HQ2jd6IrWFWyVmqOvt0oPXLZIVIJw4wEWIuxPQmL%2BbNUYg0Gla8HJNKF0t2Dy6Nu3toNo0eUE9LQuaCooOKSXRLAvstzWE3b1OBvukRevjApOBwysWftIH68TPfdfGqoI46cGvtQSSBa9XfwItNUQlxy5wkzec6mo0fo5%2BU%2FIyWfUxNUP0DeD9aVFAT92qKoIP%2FjgVSJQAJYjel1l25lRZkDUGArF8s8dfwCcsd4clZUdhA9oOhzyZ3C%2BXhulxaP2mrw%3D%3D--epZzw2GrCwQjH%2F65--%2Fqk8axLqHwM4EWz0V2zmbw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1336655701.1760197525; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:45:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:45:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CB3E:8729A:612A61:7B1F1C:68EA7B95
Add Navigation Add Page Button by getdave · Pull Request #71192 · WordPress/gutenberg · GitHub
getdave
changed the title
Add Navigation Add Page Button and fix contentOnly mode support
Add Navigation Add Page Button
Aug 13, 2025
getdave
added
[Type] Enhancement
A suggestion for improvement.
[Block] Navigation
Affects the Navigation Block
[Feature] Write mode
labels
Aug 13, 2025
getdave
requested review from
andrewserong,
jeryj,
richtabor,
scruffian and
talldan
August 13, 2025 13:00
getdave
added
the
[Status] Blocked
Used to indicate that a current effort isn't able to move forward
label
Sep 1, 2025
getdave
force-pushed
the
try/add-page-button-nav-block
branch
from
September 3, 2025 17:00
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add Navigation Add Page Button #71192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
changed the title
getdave
added
[Type] Enhancement
getdave
requested review from
andrewserong,
jeryj,
richtabor,
scruffian and
talldan
getdave
commented
Aug 13, 2025
Comment on lines
3
to
4
| kind: 'post-type', | ||
| type: 'page', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't strictly related, but I've noticed over the course of several PRs that the default block shoudl also include these attributes in it's definition to ensure the "page" variation is added with the correct attributes from the get-go.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +200 B (+0.01%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8435b29. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17440755540
|
|
I'm not sure about showing the LinkUI on the canvas in Write Mode - the alternative is to open it in the InspectorControls. The advantage of doing it in the canvas is that the connection between the button and the UI is clear. My hesitation is that we don't have other instances of inserting blocks when in |
|
I also discovered a problem whereby, if I don't select a page, and navigate away the link itself and LinkUI stay open on the page. |
|
Yeh I didn't think of that. We need my other PR which normaliazes the behaviour between canvas and list view. Then we can see how this behaves in write mode. |
|
I think we need:
That said, the new block will still end up being focused in the canvas. To make it work in the sidebar we'd need to tap into the same manual insertion tracking that we use there which is going to be very challenging 😬 |
getdave
added
the
[Status] Blocked
- Creates a new hook that adds an Add page button to Navigation blocks - Button appears in the block toolbar when Navigation block is selected - Clicking the button inserts a new navigation-link block at the end - Hook follows the same pattern as navigation-link-view-button.js - Button works in all editing modes (not just contentOnly)
- Added useBlockEditingMode hook import - Used useBlockEditingMode() to get current block editing mode - Fixed undefined blockEditingMode variable error - Navigation Link Block now properly respects contentOnly mode
- Moved NavigationAddPageButton component directly into Navigation block edit/index.js - Added required imports: ToolbarButton, ToolbarGroup, page icon, createBlock, __unstableBlockToolbarLastItem - Removed old navigation-add-page-button.js hook file - Removed import from hooks/index.js - Component now renders directly in Navigation block when isEntityAvailable is true - Maintains same functionality: only shows in contentOnly mode
- Import DEFAULT_BLOCK from ../constants - Replace hardcoded 'core/navigation-link' with DEFAULT_BLOCK.name - Makes the code more maintainable and consistent with constants usage
- Pass kind and type attributes from DEFAULT_BLOCK constant to createBlock - Ensures new navigation link blocks are created with consistent default attributes - Makes the block creation more robust and aligned with constants
getdave
force-pushed
the
try/add-page-button-nav-block
branch
from
03e4cee to
9ea7f4d
Compare
|
Not related to this PR, but this change makes this tool tip look more obviously wrong - I think we should change it to "Add page", but in a followup of course :) |
scruffian
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a step in the right direction. I'm curious to see how this will work with #71469...
I agree. Please see #71502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Feature] Write mode
[Status] Blocked
Used to indicate that a current effort isn't able to move forward
[Type] Enhancement
A suggestion for improvement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What
This PR adds a Navigation Add Page Button that appears in Write Mode (contentOnly mode).
Why
Make it obvious how to add a new Page item to the Nav bar in content only. Part of #65699
Also related:
How
Add button to the toolbar in content only.
Testing
Important: Required block.json Changes
**For the Navigation block to be selectable in contentOnly mode, the following diff must be applied:
This change adds
"role": "content"to therefattribute, which is essential for:Related Issues
This PR addresses part of the requirements in Issue #65699 - "Navigation Block: develop a content-only representation". While this PR doesn't close that issue, it implements the foundational changes needed for the Navigation block to be properly selectable and editable in contentOnly mode.
Screenshots
Screen.Capture.on.2025-09-03.at.18-10-49.mp4