| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:46:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=378.058445,conversation_content-fragment;desc="conversation_content fragment";dur=1590.925687,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=427.874267,nginx;desc="NGINX";dur=1.30547,glb;desc="GLB";dur=138.787569
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=22rTBk8XlSC5VzTPU4YCJrqnQred%2Fb7WW3%2FHkAbWLVSvQEFqZGgVPpeYlXm515gQNUWNsxjJavcLAUfoi7OvJhErqQjiwRNOdX9mUawBi6M8khFfsKNlelp53KSe7h8w%2BAC%2FU6ctvtWE%2FTNYwYYTsJ2d77CoN1SpIIgruK8C%2FOcGdBHLy5APF0nzelZA8P8pCPs4euJE9kcgb8I0Av4XJiRnsY3WnVxvA1rKU7nkdis%2BuvUCENcj590WzY8FSPzeY1IvtnDzR3FY0at2UIZZOA%3D%3D--U1dhlZnchapMWGRQ--7MGeJqrTKxBtCQooHcCGFQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1825791753.1760197596; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:46:36 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:46:36 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C170:364294:821C0E:AB28F4:68EA7BDC
DataForm: Row Layout by gigitux · Pull Request #71124 · WordPress/gutenberg · GitHub
oandregal
force-pushed
the
add/dataviews-card-layout
branch
2 times, most recently
from
August 14, 2025 14:17
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
DataForm: Row Layout #71124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DataForm: Row Layout #71124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… positions to 'none' for better UI consistency.
…nberg into add/dataviews-card-layout
…nberg into add/dataviews-card-layout
|
Flaky tests detected in b119908. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17495985145
|
oandregal
force-pushed
the
add/dataviews-card-layout
branch
2 times, most recently
from
9f8cb83 to
f9e1609
Compare
|
Size Change: +699 B (+0.04%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
dinhtungdu
reviewed
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is testing well on my end. I have a question: At this point, we have multiple layouts, and the logic of those layouts shares many similarities. Is it worth some extraction (in future PRs)?
I also found some issues:
Are the double labels here expected? No, right?
I think we need a basic responsive layout here. On mobile, the field should be full-width.
| const LayoutRowComponent = ( { | ||
| alignment, | ||
| }: { | ||
| alignment: 'none' | 'start' | 'center' | 'end'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Row layout type doesn't has none option. I think we need to use the same type here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Fixed with 1074cd9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is empty, is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed it! I removed it. 504fe4a
| return ( | ||
| <VStack className="dataforms-layouts-row__header" spacing={ 4 }> | ||
| <HStack alignment="center"> | ||
| <Heading level={ 2 } size={ 13 }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the heading here always at the same level and size, even when rows can be nested? I can see that the Regular layout has the same implementation, so this is not a question specifically for Row.
I'm not able to replicate it: 
Did you change something? |
oandregal
reviewed
Sep 1, 2025
packages/dataviews/src/types.ts
Outdated
| }; | ||
| export type NormalizedRowLayout = { | ||
| type: 'row'; | ||
| spacing: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| spacing: number; |
9 tasks
44 tasks
|
@oandregal Thanks for your help! For me, this approach works well even if this does not make the wrapper customizable for third-party layouts, but we can iterate. I think that removing the
@dinhtungdu I agree, but I’d suggest shipping this PR as is and handling layout improvements in follow-ups. Adding wrap affects current stories since inputs are set to 100% width: Screen.Capture.on.2025-09-05.at.12-45-08.mp4I’d merge this PR, gather feedback, and expand layout options based on real use cases. Thoughts? |
@gigitux Sounds good to me! |
Can you expand on this? I'd like to get clarity on this before shipping. We don't have any 3rd party layout for now, but the idea is layouts provide |
dinhtungdu
approved these changes
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest updates, this is LGTM! Thank you so much for working on this!
Sorry for not being clear (I'm still recovering from the flu 😅). I intended to say that this is a first step toward allowing third party layouts, but we need to figure out what the API will look like and we can do in the upcoming iterations.
Make sense! 💯 |
oandregal
approved these changes
Sep 5, 2025
ayushpahwa
reviewed
Sep 16, 2025
| @@ -0,0 +1,3 @@ | |||
| .dataforms-layouts-row__field-control { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gigitux I don't see this file being imported anywhere. This is causing the UI of the elements to not take the full width. I did a [local override] for now but I think it is better to import this file to the adjacent index.tsx file. cc: @ismaeldcom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is imported correctly here.
Maybe I think that you need to import dataviews CSS in your SCSS file with:
@use "@wordpress/dataviews/build-style/style.css" as dataviews;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What
This PR introduces a new layout for the DataForm component. The row layout allows grouping fields horizontally in a single line.
How
Add 'row' as a new layout type alongside existing 'regular', 'panel', and 'card'.
The row layout supports:
Example
Screen.Capture.on.2025-08-27.at.14-28-06.mov