You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that because the class name prop is hard-coded, the block editor is not applying the proper CSS classes, and I couldn’t even select the block itself. This issue only occurs when the form block is nested. I don't know why it worked fine at the root level, but it was probably just a coincidence.
How?
Remove the hard-coded classname.
Note: This PR is effectively a part of #55755, and the issues occurring on the frontend need to be fixed separately.
Testing Instructions
Insert a Form Block.
Wrap the block with a Group block.
Open the list view.
Click the "Experimental Comment Form" row.
Make sure you can select the block and that the block sidebar is visible.
Click a block inside the Form block.
Click the Parent Block Selection button on the left of the block toolbar.
Make sure the Form block is selected.
Screenshots or screencast
The following screencast shows the issue occurring in the trunk branch:
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I noticed that because the class name prop is hard-coded, the block editor is not applying the proper CSS classes, and I couldn’t even select the block itself. This issue only occurs when the form block is nested. I don't know why it worked fine at the root level, but it was probably just a coincidence.
How?
Remove the hard-coded classname.
Note: This PR is effectively a part of #55755, and the issues occurring on the frontend need to be fixed separately.
Testing Instructions
Screenshots or screencast
The following screencast shows the issue occurring in the trunk branch:
3d5e5e0ff165099cff4afb72f0023528.mp4