You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors URLInputButton component from class based component syntax to newer functional component syntax.
Why?
Class based components are no longer the recommended approach & instead functional syntax with hooks is more recommended
The code becomes more readable & easier to make changes to
How?
React hooks are used for component lifecycle methods
Rest of component logic remains the same
Testing Instructions
To test this component try converting any text to link
The toolbar button for adding link is provided by this component
The component should behave same as before
Screenshots or screencast
I'm new to gutenberg contributions, feel free to provide suggestions for improvement & pointing out mistakes
Thanks!
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #22890
This PR refactors
URLInputButton
component from class based component syntax to newer functional component syntax.Why?
Class based components are no longer the recommended approach & instead functional syntax with hooks is more recommended
The code becomes more readable & easier to make changes to
How?
Testing Instructions
Screenshots or screencast
I'm new to gutenberg contributions, feel free to provide suggestions for improvement & pointing out mistakes
Thanks!