You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
π Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @yashjawale! In case you missed it, we'd love to have you join us in our Slack community.
If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
yashjawale
changed the title
fix: update double tap hint in native image component
Image: Fix outdated accessibility hint on native component
Jun 6, 2025
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @yashjawale! The proposed changes make sense and accomplish the first of the two changes referenced in #45124 (comment).
In the name of transparency, I'll share that development of the native mobile editor (Gutenberg Mobile) is currently in a hiatus. We are exploring a different, WebView-based approach in GutenbergKit.
I'll merge this improvement, but wanted to note that it is unlikely to be published in a new editor release for the foreseeable future.
Regardless, thank you, again, for helping move the project forward. ππ»ββοΈ
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the outdated accessiblity hint in native image component.
It was agreed to solve this issue in two steps in the issue discussion...
See #45124
Why?
Since the long press event was disabled in PR #40651
The current hint
Double tap and hold to edit.
is no longer relevant & needs to be replaced byDouble tap to view larger.
How?
This PR completes step 1 of the fix
Next step will be to add dynamic hints according to media states
Testing Instructions [on mobile]
Screenshots or screencast
Tested with iOS simulator, with iPhone 16 Plus iOS 18.5
Thanks!