You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getHomePage currently returns an object ({ postType: 'wp_template', postId: null }) while getDefaultTemplateId is still resolving. It should return null instead until it's fully resolved.
Why?
We can't do much with partially resolved data. In fact, can do harm because for a user without the necessary caps, it will return the same object, which makes it impossible to differentiate between loading state and a user without privileges.
How?
Return null until getDefaultTemplateId returns an ID.
Testing Instructions
For a site without a front-page set, load the root of the site editor. It should still work.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes
getHomePage
currently returns an object ({ postType: 'wp_template', postId: null }
) whilegetDefaultTemplateId
is still resolving. It should returnnull
instead until it's fully resolved.Why?
We can't do much with partially resolved data. In fact, can do harm because for a user without the necessary caps, it will return the same object, which makes it impossible to differentiate between loading state and a user without privileges.
How?
Return null until
getDefaultTemplateId
returns an ID.Testing Instructions
For a site without a front-page set, load the root of the site editor. It should still work.
Testing Instructions for Keyboard
Screenshots or screencast