You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where HTML comments appear at the end of an element (that is, they don't have a next sibling). E.g.:
<uldata-wp-interactive="example"><li>Item 1</li><li>Item 2</li><!-- End of list (HTML comment without a next sibling) --></ul>
The toVdom() function was wrongly expecting a sibling after processed comments. The same thing happens for processing instructions and CDATA blocks since they are processed in the same way as comments.
The toVdom() function now waits until the end of the current element processing to delete the comments (also delete the processing instructions and transform CDATA blocks into text). This prevents execution failure once the function reaches treeWalker.parentNode() and the parent doesn't exist (because the current node has been deleted or replaced).
Additionally, it is no longer necessary for toVdom (and internally walk) to return an array. This has been conveniently updated.
Tests
The previous e2e tests have been updated, and a comprehensive unit test suite for toVdom() has been implemented.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in 6a9fa51.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
* Add suite of tests for the toVdom function
* Fix tests
* Replace CDATA and add test coverage
* Move sets inside toVdom
* Don't return an array in `toVdom`
* Update tests for the last-child comment or processing instruction node
* Update directive-priorities test
* Update changelog
---------
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug where HTML comments appear at the end of an element (that is, they don't have a next sibling). E.g.:
The
toVdom()
function was wrongly expecting a sibling after processed comments. The same thing happens for processing instructions and CDATA blocks since they are processed in the same way as comments.Props to @luisherranz.
Why?
This case passed under the radar.
How?
The
toVdom()
function now waits until the end of the current element processing to delete the comments (also delete the processing instructions and transform CDATA blocks into text). This prevents execution failure once the function reachestreeWalker.parentNode()
and the parent doesn't exist (because the current node has been deleted or replaced).Additionally, it is no longer necessary for
toVdom
(and internallywalk
) to return an array. This has been conveniently updated.Tests
The previous e2e tests have been updated, and a comprehensive unit test suite for
toVdom()
has been implemented.