You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents duplicating nested router regions after a client-side navigation.
Nested regions may appear when an interactive block with a router region (e.g., the Query block) is placed within another interactive block with its router region (which could be another Query block instance). In this case, the nested router region is rendered twice: as part of the parent block's Preact application and as a separate Preact application, resulting in duplicated HTML.
Additionally, since a requirement of data-wp-router-region is that it must be in the top-most data-wp-interactive element, this PR ensures that it ignores all regions that do not meet this requirement.
Why?
Nested router regions should not be processed; only the top-most region should, as nested regions become part of the same Preact application.
How?
Changing the selector to only take into account the regions that are not nested and that also include a top-most data-wp-interactive element.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Prevents duplicating nested router regions after a client-side navigation.
Nested regions may appear when an interactive block with a router region (e.g., the Query block) is placed within another interactive block with its router region (which could be another Query block instance). In this case, the nested router region is rendered twice: as part of the parent block's Preact application and as a separate Preact application, resulting in duplicated HTML.
Additionally, since a requirement of
data-wp-router-region
is that it must be in the top-mostdata-wp-interactive
element, this PR ensures that it ignores all regions that do not meet this requirement.Why?
Nested router regions should not be processed; only the top-most region should, as nested regions become part of the same Preact application.
How?
Changing the selector to only take into account the regions that are not nested and that also include a top-most
data-wp-interactive
element.The PR includes e2e tests for this bug fix.