You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the tests environment in wp-env uses the port 8889. On my system, I am overriding this via .wp-env.override.json use a different port number for the development and tests environments:
This is important to override because the WordPress/wordpress-develop repo also uses the 8889 port for its development environment. In this way the Gutenberg environment can run at the same time as the wordpress-develop environment.
Nevertheless, even though I overrode the tests port to be 8991, I found that when I ran npm run test:e2e it would run the tests still on https://localhost:8889. The result is that it clobbered the database of my wordpress-develop environment, leaving me with zero published posts and Twenty Twenty-One theme active. The command fails as well with an error:
Error: The plugin "gutenberg-test-plugin-disables-the-css-animations" isn't installed
This is expected given that the wordpress-develop environment is not the same as the Gutenberg test environment which has that plugin installed.
If I tried modifying the .env file in wordpress-develop to use a different port number, like 18889, then npm run test:e2e fails with:
Error: Process from config.webServer exited early.
Also, this is expected because it is (erroneously) looking to use the test server at port 8889, when according to my .wp-env.override.json it should be using port 8991.
So this PR fixes the issue by loading up the current WPConfig in order to obtain the envConfig.env.tests.port. This is then passed to Playwright via the WP_BASE_URL environment variable if one is not already set.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the
tests
environment inwp-env
uses the port8889
. On my system, I am overriding this via.wp-env.override.json
use a different port number for thedevelopment
andtests
environments:This is important to override because the
WordPress/wordpress-develop
repo also uses the8889
port for its development environment. In this way the Gutenberg environment can run at the same time as the wordpress-develop environment.Nevertheless, even though I overrode the
tests
port to be8991
, I found that when I rannpm run test:e2e
it would run the tests still onhttps://localhost:8889
. The result is that it clobbered the database of my wordpress-develop environment, leaving me with zero published posts and Twenty Twenty-One theme active. The command fails as well with an error:This is expected given that the wordpress-develop environment is not the same as the Gutenberg test environment which has that plugin installed.
If I tried modifying the
.env
file in wordpress-develop to use a different port number, like 18889, thennpm run test:e2e
fails with:Also, this is expected because it is (erroneously) looking to use the test server at port
8889
, when according to my.wp-env.override.json
it should be using port8991
.So this PR fixes the issue by loading up the current
WPConfig
in order to obtain theenvConfig.env.tests.port
. This is then passed to Playwright via theWP_BASE_URL
environment variable if one is not already set.