You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR normalizes user input from full-width characters to half-width characters internally.
Why?
In #70178, a process was added to normalize suggestions to half-width characters. This means that, for example, when searching for the half-width character string WordPress, it will match not only the half-width character string WordPress but also the full-width character string οΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½.
However, we did not normalize user input. As a result, when a user searches for the full-width character string οΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½, the full-width character string οΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½ included in the suggestions will no longer match because it has already been normalized to half-width characters.
How?
Normalize user input from full-width characters to half-width characters
Add a unit test to prevent a regression
Testing Instructions
Make the following changes and launch the FormTokenField or ComboboxControl story:
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up: #70180
What?
This PR normalizes user input from full-width characters to half-width characters internally.
Why?
In #70178, a process was added to normalize suggestions to half-width characters. This means that, for example, when searching for the half-width character string
WordPress
, it will match not only the half-width character stringWordPress
but also the full-width character stringοΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½
.However, we did not normalize user input. As a result, when a user searches for the full-width character string
οΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½
, the full-width character stringοΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½
included in the suggestions will no longer match because it has already been normalized to half-width characters.How?
Testing Instructions
Make the following changes and launch the
FormTokenField
orComboboxControl
story:Or add
WordPress
andοΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½
as post tags and open the post sidebar.οΌ·ο½ο½ο½
.WordPress
andοΌ·ο½ο½ο½οΌ°ο½ο½ ο½ο½
should match.Word
orοΌ·ο½ο½ο½
part should be in bold.Screenshots or screencast