You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the "Columns" setting is not a block attribute but represents the actual number of columns, it is difficult to define what the default is. Furthermore, if we reset the Columns setting, we lose focus.
How?
There are several possible approaches, but I think it's better not to use ToolsPanelItem for this setting. This will prevent the reset, and there's no need to add a new API to the ToolsPanelItem component itself.
Testing Instructions
Add a Columns block.
Check the Settings panel.
Confirm the Settings Options dropdown doesn't have the "Columns" menu item.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in 022bece.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
[Block] ColumnsAffects the Columns Block[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).[Type] BugAn existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
ToolsPanel
instead ofPanelBody
#67918Why?
Because the "Columns" setting is not a block attribute but represents the actual number of columns, it is difficult to define what the default is. Furthermore, if we reset the Columns setting, we lose focus.
How?
There are several possible approaches, but I think it's better not to use
ToolsPanelItem
for this setting. This will prevent the reset, and there's no need to add a new API to theToolsPanelItem
component itself.Testing Instructions
Screenshots or screencast