| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 14 Oct 2025 03:43:40 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=453.407835,conversation_content-fragment;desc="conversation_content fragment";dur=1475.506767,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=393.753834,nginx;desc="NGINX";dur=0.540316,glb;desc="GLB";dur=140.043354
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jm74Gu9atWbszELvdB61un1OKjP94aoCdOWsdL%2B7raRQwZTq8K48DGUGJyiC8lHf3P%2FMaAprAd5X7YQJrZ3xw2MsXjaHo5rOk%2BjkOm%2Bo6dnPYucmD3NN8fgtRWlhcaUqsneF5G0yN828T%2BwFl61emfyM4WL1Hvhtw28G5tiZ8lnnJh5VOTpQu1phTrq3SeA1VDMWy9tRrF9du6q3JTeWnkfmRJh2AfEMxHOrr%2BnRu1Eq5%2Bx%2FofQcR3gUmEgUS6tR%2FfUMH3%2FGyGBHI8EUicd2JQ%3D%3D--DKotiur63rxlGteO--n36hVj5k08WRJH4hWfGtZA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.130205781.1760413418; Path=/; Domain=github.com; Expires=Wed, 14 Oct 2026 03:43:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Oct 2026 03:43:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B536:40E8D:26B5AD:36AD18:68EDC6EA
Editor: Add label in`TextareaControl` in CollabSidebar by im3dabasia · Pull Request #70133 · WordPress/gutenberg · GitHub
Editor: Add label in
t-hamano
added
[Type] Bug
An existing feature does not function as intended
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
labels
May 16, 2025
im3dabasia
force-pushed
the
fix/labels-in-control
branch
from
May 16, 2025 10:50
im3dabasia
changed the title
Components: Add labels to interactive controls
Editor: Add label in May 16, 2025
im3dabasia
changed the title
Editor: Add label in
Editor: Add label inMay 16, 2025
t-hamano
added
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
and removed
Collaborative Workflows
Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows
labels
Oct 4, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Editor: Add label inTextareaControl in CollabSidebar
#70133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
May 16, 2025
t-hamano
added
[Type] Bug
t-hamano
reviewed
May 16, 2025
im3dabasia
force-pushed
the
fix/labels-in-control
branch
from
cdd9a22 to
d4af295
Compare
t-hamano
approved these changes
May 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@im3dabasia Can you update the PR title and description with the actual code changes? I think this PR purely makes changes to the collaboration sidebar only. |
im3dabasia
changed the title
TextareaControl in CollabSidebar
im3dabasia
changed the title
TextareaControl in CollabSidebarTextareaControl in CollabSidebar
@t-hamano , Fixed it. 💯 |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* feat: Add labels in menu and comment-form * feat: Add labels in menu and comment-form * fix: Add official label prop and hideLabelFromVision * revert: Label in search-control Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
t-hamano
added
[Feature] Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Notes
Phase 3 of the Gutenberg roadmap around block commenting
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Bug
An existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Part of: #51740
I conducted an extensive search throughout the codebase to identify controls that are unlabeled and found 1 such instance:
TextareaControlinCommentFormWhy?
All form controls must be labeled.
How?
TextareaControlinCommentForm.Testing Instructions
Screenshot