You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the View Post links in the Post Publish Panel to open in new tabs, ensuring a smoother editing workflow by preserving the current editor session.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Note that these two buttons are expected to change to a vertical layout if the button text is long.
Thanks for pointing that out! The issue was caused by the .has-icon class adding a min-width. I've fixed it, and it should now work as expected. Please have a look when you get a moment.
* Post Publish Panel: Open view post in new tab
* chore: fix import order
* chore: update unit test snapshots
* chore: update e2e tests
* chore: update e2e test
* fix: let the button stack up if the text is large
* chore: update `publishPost` to use a11y locators
* fix: simplify visiting published post logic
* fix: remove rel attribute
* chore: update snapshots
Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: HILAYTRIVEDI <hilayt24@git.wordpress.org>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What, Why, and How?
Closes #70126
This PR updates the
View Post
links in thePost Publish Panel
to open in new tabs, ensuring a smoother editing workflow by preserving the current editor session.Testing Instructions
View Post
.Testing Instructions for Keyboard
Same.
Screenshots
Screencast
post-publish-demo.mov