You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning message shown previously was static. This PR aims to make the Stylelint warning related to non-usage of row-reverse/column-reverse in flex-direction dynamic. This would improve the warnings and make them dynamic. first suggested in this issue #63090
we'll probably want to convert the .stylelintrc.json to a .stylelintrc.js at this point, so we can configure the message as a function to show different warning messages for each violation. It looks like we'll also need to update our stylelint dependency to achieve that. Our repo is at stylelint 14.2, whereas the feature we need is available from 14.5.0.
How?
After the Stylelint configuration was updated to JavaScript via #69590, now custom warnings can be shown for custom rules.
Testing Instructions
Checkout any file which already has a flex-direction property.
Change the property from row/column to row-reverse/column-reverse. In short append reverse.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
We have one more rule for Stylelint in packages/components which prevents use of --wp-components-color-* variables outside packages/components. Since its a related change I think its a good time to get this rule display dynamic warnings like this:
'declaration-property-value-disallowed-list': [{'/.*/': ['/--wp-components-color-/'],},{message: (property,value)=>`Avoid using "${value}" in "${property}". --wp-components-color-* variables are not ready to be used outside of the components package.`,},],
I was wondering we can update this message as well, looking forward to your thoughts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Followup: #69590 (review)
The warning message shown previously was static. This PR aims to make the Stylelint warning related to non-usage of
row-reverse/column-reverse
inflex-direction
dynamic. This would improve the warnings and make them dynamic. first suggested in this issue #63090Originally reported here:
How?
After the Stylelint configuration was updated to JavaScript via #69590, now custom warnings can be shown for custom rules.
Testing Instructions
row/column
torow-reverse/column-reverse
. In short append reverse.Screencast
Before
Screen.Recording.2025-05-05.at.4.54.50.PM.mov
After
Screen.Recording.2025-05-05.at.5.03.35.PM.mov