You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the style selector for buttons to this:
// From
.wp-block-button__link {
width:100%;
}
// To
.wp-block-buttons .wp-block-button__link {
width:100%;
}
Why?
The width: 100% style is needed to stretch the buttons in the vertical layout. However, the .wp-block-button__link selector resulted in forcing the button's width to 100% width even though the button was not a child of a flex layout, such as in the following HTML:
This problem occurred in the Post Comments Form block, so we fixed the problem in #69651. However, it's possible that consumers are using this button selector in other places as well.
How?
Apply 100% width style to only the button links inside the buttons.
Testing Instructions
Insert a Buttons block.
Change the justification to "Stretch items" and change the orientation to "Vertical".
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://core.trac.wordpress.org/ticket/63373
Follow-up on #64770 and #69651
What?
This PR changes the style selector for buttons to this:
Why?
The
width: 100%
style is needed to stretch the buttons in the vertical layout. However, the.wp-block-button__link
selector resulted in forcing the button's width to 100% width even though the button was not a child of a flex layout, such as in the following HTML:This problem occurred in the Post Comments Form block, so we fixed the problem in #69651. However, it's possible that consumers are using this button selector in other places as well.
How?
Apply 100% width style to only the button links inside the buttons.
Testing Instructions