You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds summary element to the focusable elements defined in the @wordpress/dom/package so that the focus.focusable.find() method detects the element as a focusable element.
Why?
This PR is needed to fix one of the issues reported on #70050.
How?
Simply added the summary element. Note that this element only supports the global attributes, so we don't need to check the disabled attribute.
Testing Instructions
Activate a classic theme.
Create a new page and insert a Details block.
Set the page as Homepage.
Access Appearance > Design
Confirm that clicking the summary element does nothing.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Strictly speaking, this issue with the DOM package has existed for some time. However, this PR may be a prerequisite for solving #69522 and #70047, so I will add the "Backport to WP Minor Release" label. Both #69522 and #70047 are problems that are new to WordPress 6.8.
I am checking the PRs with the "Backport to WP Minor Release" label applied to clarify which PRs should be backported to the WordPress 6.8.2 release.
Strictly speaking, this issue with the DOM package has existed for some time. However, this PR may be a prerequisite for solving #69522 and #70047, so I will add the "Backport to WP Minor Release" label. Both #69522 and #70047 are problems that are new to WordPress 6.8.
For the reasons above, I think this PR should be backported to 6.8.2.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #70050
What?
Adds
summary
element to the focusable elements defined in the@wordpress/dom/package
so that thefocus.focusable.find()
method detects the element as a focusable element.Why?
This PR is needed to fix one of the issues reported on #70050.
How?
Simply added the
summary
element. Note that this element only supports the global attributes, so we don't need to check thedisabled
attribute.Testing Instructions