| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 09:47:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=411.469827,conversation_content-fragment;desc="conversation_content fragment";dur=579.152801,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=283.505755,nginx;desc="NGINX";dur=0.875111,glb;desc="GLB";dur=136.805082
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=DaJZAisWnf%2BUZyHPRhYEkJk7STgLfl8E10oXXGQWMeTTLWAoUb0s4E85oyMzSq3o0xQYDWFHBnInqkmcNQ2n3YtwtLGJTJ%2B7iJZkn8tz4oItTBd%2F8yZfE192Hj77iOPalgsf7iiEIsCwJq%2BL40T27MN0O6MoKokntiloC%2FDJxOlvqzSJFxJHIEVhP11lX%2FTCt0OrHasz0TOm9qIdGTKBmFZoj68dBRDOqUeNqE6huVY6%2Fnr9iyrxzrioc9LmpT0xZlobwbLUWMGoraBC4Pns%2FA%3D%3D--lVEqG4%2FgxUGn1VdM--2vWqD5lySH48Tl9A9Z1UnA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1264781082.1760176033; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:47:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:47:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 95CE:123F70:54F4A1:728E03:68EA27A1
Components: Fix double border in `ItemGroup` when last item is focused by im3dabasia · Pull Request #70021 · WordPress/gutenberg · GitHub
Components: Fix double border in
Components: Fix double border in
Mamaduka
added
[Type] Bug
An existing feature does not function as intended
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
labels
Apr 30, 2025
im3dabasia
force-pushed
the
fix/item-group-double-border
branch
from
May 2, 2025 10:58
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Components: Fix double border in ItemGroup when last item is focused
#70021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 3 commits into
WordPress:trunk
from
im3dabasia:fix/item-group-double-border
May 3, 2025
Merged
Components: Fix double border in ItemGroup when last item is focused
#70021
t-hamano
merged 3 commits into
WordPress:trunk
from
im3dabasia:fix/item-group-double-border
May 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Bug
t-hamano
reviewed
May 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I've read all of #30097 where this style was added, but I'm really not sure why :focus state was ignored from the selector. Perhaps it may be necessary for the first implementation, but I believe it shouldn't be needed anymore for now.
The snapshots for the tests need to be updated thats probably the reason why unit tests are failing. I am not aware on how to update them. I would appreciate some guidance here.
Run: npm run test:unit packages/components/src/item-group/test/index.js -- -u
im3dabasia
force-pushed
the
fix/item-group-double-border
branch
from
eedaec5 to
1c6040d
Compare
t-hamano
approved these changes
May 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
WordPress#70021) * fix: Make border transparent for all pseudo events * chore: Add changelog entry * chore: Update snapshots Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
[Type] Bug
An existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #61621
Fixes double border issue in
ItemGroupwhen last item is focused.Why?
Previously, the border was only removed when the item was not focused, causing a double border when the last item received focus.
How?
Modified the separated CSS to remove the bottom border on the last child item in all states rather than only in the non-focused state.
Testing Instructions
npm run storybook:devto start the storybook.ItemGroupcomponent in Storybook.:focusstate on the last item using browser developer tools.Notes
The snapshots for the tests need to be updated thats probably the reason why unit tests are failing. I am not aware on how to update them. I would appreciate some guidance here.
Screenshots or screencast
Before
Screen.Recording.2025-04-30.at.4.58.00.PM.mov
After
Screen.Recording.2025-04-30.at.4.56.24.PM.mov