You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR removes the condition for preserving the url attribute when selecting the same image from Media Library, which can cause subtle bugs as described in the linked issue.
The condition was initially introduced in #16125 to avoid resetting the image "Resolution" setting, but it's no longer necessary after #49982.
Testing Instructions
Create a post.
Add two image blocks and select different images.
Using a code editor, update the image's src so that both blocks point to the same image.
Select the image block where ID and src don't match and click "Replace".
Confirm that the image points to the correct item in the media library (selection happens based on ID).
Select the same image from the library.
Confirm that the block now has the correct src URL.
Flaky tests detected in bd06953.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
Unlinked Accounts
The following contributors have not linked their GitHub and WordPress.org accounts: @T4ngml.
I am checking the PRs with the "Backport to WP Minor Release" label applied to clarify which PRs should be backported to the WordPress 6.8.2 release.
The issue this PR fixes is not new for 6.8, but it is a very useful improvement, and I think it would be a good idea to include it in the 6.8.1 release.
[Block] ImageAffects the Image Block[Type] BugAn existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69965.
PR removes the condition for preserving the
url
attribute when selecting the same image from Media Library, which can cause subtle bugs as described in the linked issue.The condition was initially introduced in #16125 to avoid resetting the image "Resolution" setting, but it's no longer necessary after #49982.
Testing Instructions
src
so that both blocks point to the same image.ID
andsrc
don't match and click "Replace".src
URL.Testing Instructions for Keyboard
Same.