| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 07:37:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=551.118777,conversation_content-fragment;desc="conversation_content fragment";dur=942.882951,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=470.69886,nginx;desc="NGINX";dur=1.38708,glb;desc="GLB";dur=145.44899
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=d8IO%2BmJMlD5K3Ca%2BKBWqsYdrkhjTwwtQIh6oHbZBjObkXQqgQPLvAJ2s1nuhAv3WmssOQXtSMaljLOiokLit0Xi%2FHDuFbr2l7TTjAqIr%2F56aHDQueV3AP2BXYUDCg8xJzkON3DmZ9xert1P1t09vucICzW8XnVnOsNf9PhpAbBDdi0IetoJXz4spvx3g%2Frxq%2B90%2B9eR08R2Ptcra%2FSWZN4X%2F%2Bnh%2FaBBprVyz28OxXzE%2BOCClqw8Wmy0ObZv%2B6tcw0RCZ72ZBrpiVxE%2BA0umAmQ%3D%3D--SObsAopmJ4RR3fis--GDTzKdyKXwmA1qFzMBZ7dQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.347872827.1760168257; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 07:37:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 07:37:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A0B2:136466:437598:5CECE1:68EA0941
Edit Widgets: save lock control via actions by Infinite-Null · Pull Request #69984 · WordPress/gutenberg · GitHub
Infinite-Null
force-pushed
the
add/widget-save-lock
branch
from
April 28, 2025 08:49
t-hamano
added
[Type] Enhancement
A suggestion for improvement.
[Package] Edit Widgets
/packages/edit-widgets
[Type] New API
New API to be used by plugin developers or package users.
labels
Apr 28, 2025
Infinite-Null
requested review from
adamziel,
ajitbohra,
draganescu,
fabiankaegy,
juanmaguitar,
kevin940726 and
ndiego
as code owners
April 30, 2025 07:05
adamsilverstein
added
[Type] New API
New API to be used by plugin developers or package users.
[Type] Feature
New feature to highlight in changelogs.
and removed
[Type] New API
New API to be used by plugin developers or package users.
labels
Apr 30, 2025
Mamaduka
removed
[Type] Enhancement
A suggestion for improvement.
[Type] Feature
New feature to highlight in changelogs.
labels
May 1, 2025
Mamaduka
added
the
props-bot
Manually triggers Props Bot to ensure the list of props is up to date.
label
May 1, 2025
github-actions
bot
removed
the
props-bot
Manually triggers Props Bot to ensure the list of props is up to date.
label
May 1, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Edit Widgets: save lock control via actions #69984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinite-Null
force-pushed
the
add/widget-save-lock
branch
from
f12edb2 to
4f3aa62
Compare
t-hamano
added
[Type] Enhancement
Infinite-Null
requested review from
adamziel,
ajitbohra,
draganescu,
fabiankaegy,
juanmaguitar,
kevin940726 and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
added
[Type] New API
|
@Infinite-Null overall this looks really good. I had some trouble testing, I was getting JavaScript errors on the edit widget screen preventing updates from working, so I couldn't test the actions directly. I am going to try resetting my local (I see the same error on trunk). |
adamsilverstein
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@Infinite-Null The PR description appears to have an error that threw me off in testing. This should be |
Mamaduka
removed
[Type] Enhancement
Mamaduka
approved these changes
May 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Infinite-Null!
Mamaduka
added
the
props-bot
github-actions
bot
removed
the
props-bot
This was related to an experiment I had enabled for testing. Once I disabled that, the errors went away and the locking mechanism worked as expected. |
|
Thanks for the update, @adamsilverstein! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jorostoyanov <stoyanovgs@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Edit Widgets
/packages/edit-widgets
[Type] New API
New API to be used by plugin developers or package users.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Add a widget save locking feature. Plugins can add and remove locks and when any locks are present, the update button is disabled.
Closes #33756
Why?
There was no API for developers to lock widget saving, like there was for post saving.
How?
isWidgetSavingLockedselectorisWidgetSavingLockedin the widget update buttonTesting Instructions
wp.data.dispatch( 'core/edit-widget' ).lockWidgetSaving( 'mylock' );wp.data.dispatch( 'core/edit-widget' ).unlockWidgetSaving( 'mylock' );Screencast:
Screen.Recording.2025-04-30.at.12.32.59.PM.mov